[PHPUnit 12] Add CreateStubOverCreateMockArgRector

config/sets/phpunit120.php

@@ -3,9 +3,16 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
+use Rector\PHPUnit\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector;
 use Rector\PHPUnit\PHPUnit120\Rector\Class_\AssertIsTypeMethodCallRector;
 use Rector\PHPUnit\PHPUnit120\Rector\Class_\RemoveOverrideFinalConstructTestCaseRector;
 
 return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([RemoveOverrideFinalConstructTestCaseRector::class, AssertIsTypeMethodCallRector::class]);
+    $rectorConfig->rules([
+        RemoveOverrideFinalConstructTestCaseRector::class,
+        AssertIsTypeMethodCallRector::class,
+
+        // stubs over mocks
+        CreateStubOverCreateMockArgRector::class,
+    ]);
 };

rules-tests/PHPUnit120/Rector/CallLike/CreateStubOverCreateMockArgRector/CreateStubOverCreateMockArgRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class CreateStubOverCreateMockArgRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/PHPUnit120/Rector/CallLike/CreateStubOverCreateMockArgRector/Fixture/handle_static_call.php.inc

@@ -0,0 +1,37 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Utils\PHPStan\Tests\Rule\PHPUnit\StubOverMockArgRule\Source\AnyClass;
+
+class HandleStaticCall extends TestCase
+{
+    public function testThat()
+    {
+        AnyClass::staticRun(
+            $this->createMock(\stdClass::class),
+        );
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Utils\PHPStan\Tests\Rule\PHPUnit\StubOverMockArgRule\Source\AnyClass;
+
+class HandleStaticCall extends TestCase
+{
+    public function testThat()
+    {
+        AnyClass::staticRun(
+            $this->createStub(\stdClass::class),
+        );
+    }
+}
+
+?>

rules-tests/PHPUnit120/Rector/CallLike/CreateStubOverCreateMockArgRector/Fixture/some_file_with_mocks.php.inc

@@ -0,0 +1,41 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Utils\PHPStan\Tests\Rule\PHPUnit\StubOverMockArgRule\Source\AnyClass;
+
+class SomeFileWithMocks extends TestCase
+{
+    public function testThat()
+    {
+        $anyClass = new AnyClass();
+        $anyClass->run(
+            $this->createMock(\stdClass::class),
+            $this->createMock(\stdClass::class)
+        );
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Utils\PHPStan\Tests\Rule\PHPUnit\StubOverMockArgRule\Source\AnyClass;
+
+class SomeFileWithMocks extends TestCase
+{
+    public function testThat()
+    {
+        $anyClass = new AnyClass();
+        $anyClass->run(
+            $this->createStub(\stdClass::class),
+            $this->createStub(\stdClass::class)
+        );
+    }
+}
+
+?>

rules-tests/PHPUnit120/Rector/CallLike/CreateStubOverCreateMockArgRector/config/configured_rule.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\PHPUnit\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector;
+
+return RectorConfig::configure()
+    ->withRules([CreateStubOverCreateMockArgRector::class]);

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_abstract_method.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\PHPUnit\Tests\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
 
 use PHPUnit\Framework\TestCase;
 

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_call_expect_not_to_perform_assertions_method_call.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\PHPUnit\Tests\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
 
 use Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Source\Factory;
 

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_mock_expectations.php.inc

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\PHPUnit\Tests\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
 
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;

rules/PHPUnit120/Rector/CallLike/CreateStubOverCreateMockArgRector.php

@@ -0,0 +1,112 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\PHPUnit120\Rector\CallLike;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Expr\New_;
+use PhpParser\Node\Expr\StaticCall;
+use PhpParser\Node\Identifier;
+use Rector\PHPStan\ScopeFetcher;
+use Rector\PHPUnit\Enum\PHPUnitClassName;
+use Rector\Rector\AbstractRector;
+use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+/**
+ * Related change in PHPUnit 12 https://phpunit.expert/articles/testing-with-and-without-dependencies.html
+ *
+ * @see \Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\CreateStubOverCreateMockArgRectorTest
+ */
+final class CreateStubOverCreateMockArgRector extends AbstractRector
+{
+    public function getRuleDefinition(): RuleDefinition
+    {
+        return new RuleDefinition(
+            'Use createStub() over createMock() when used as argument and does not add any mock requirements',
+            [
+                new CodeSample(
+                    <<<'CODE_SAMPLE'
+use PHPUnit\Framework\TestCase;
+final class SomeTest extends TestCase
+{
+    public function test()
+    {
+        $this->someMethod($this->createMock(SomeClass::class));
+    }
+
+    private function someMethod($someClass)
+    {
+    }
+}
+CODE_SAMPLE
+                    ,
+                    <<<'CODE_SAMPLE'
+use PHPUnit\Framework\TestCase;
+
+final class SomeTest extends TestCase
+{
+    public function test()
+    {
+        $this->someMethod($this->createStub(SomeClass::class));
+    }
+
+    private function someMethod($someClass)
+    {
+    }
+}
+CODE_SAMPLE
+                ),
+
+            ]
+        );
+    }
+
+    /**
+     * @return array<class-string<Node>>
+     */
+    public function getNodeTypes(): array
+    {
+        return [StaticCall::class, MethodCall::class, New_::class];
+    }
+
+    /**
+     * @param MethodCall|StaticCall|New_ $node
+     */
+    public function refactor(Node $node): MethodCall|StaticCall|New_|null
+    {
+        $scope = ScopeFetcher::fetch($node);
+        if (! $scope->isInClass()) {
+            return null;
+        }
+
+        $classReflection = $scope->getClassReflection();
+        if (! $classReflection->is(PHPUnitClassName::TEST_CASE)) {
+            return null;
+        }
+
+        $hasChanges = false;
+
+        foreach ($node->getArgs() as $arg) {
+            if (! $arg->value instanceof MethodCall) {
+                continue;
+            }
+
+            $methodCall = $arg->value;
+            if (! $this->isName($methodCall->name, 'createMock')) {
+                continue;
+            }
+
+            $methodCall->name = new Identifier('createStub');
+            $hasChanges = true;
+        }
+
+        if ($hasChanges) {
+            return $node;
+        }
+
+        return null;
+    }
+}