[CodeQuality] Rename MatchAssertSameExpectedTypeRector to MatchAssertEqualsExpectedTypeRector to only apply on assertEquals#514
Merged
samsonasik merged 1 commit intomainfrom Aug 21, 2025
Conversation
…EqualsExpectedTypeRector to only apply on assertEquals
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Member
|
This is on purpose. The rule should handle assertSame(), please revert. |
Member
Author
|
on process: I will add test to prove invalid apply |
TomasVotruba
pushed a commit
that referenced
this pull request
Aug 21, 2025
* Revert "Drop MatchAssertEqualsExpectedTypeRector (#517)" This reverts commit a5fc689. * Revert "[CodeQuality] Rename MatchAssertSameExpectedTypeRector to MatchAssertEqualsExpectedTypeRector to only apply on assertEquals (#514)" This reverts commit 84fe73a. * add test * [ci-review] Rector Rectify --------- Co-authored-by: GitHub Action <actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see reasoning:
#510 (review)
the
assertSamematch to exact type, not loosy type, so when user use assertSame, it error on the first. That if combined toAssertEqualsToSameRector, it because changed toassertSamewhich cause error.