Only remove @covers when target exists#494
Merged
samsonasik merged 5 commits intomainfrom May 22, 2025
Merged
Conversation
Member
Author
|
It seems cause phpunit notice: @TimelessTron could you verify the use of |
Member
Author
|
Let's remove |
Member
Author
|
@TimelessTron I tested manually on phpunit 10, and it seems still remove whole + #[\PHPUnit\Framework\Attributes\CoversClass(\App\SomeException::class)]
final class SomeTraitTest extends TestCase
{
- /**
- * @covers \App\OtherStuff::Inject
- * @covers \App\SomeException
- */
- public function testYourThinks(): void
+ public function testYourThinks(): void
{} |
samsonasik
commented
May 22, 2025
Comment on lines
306
to
308
| if (str_contains($desiredTagValueNode->value->value, '::') && ! $this->reflectionProvider->hasClass(self::COVERS_METHOD_ATTRIBUTE)) { | ||
| continue; | ||
| } |
Member
Author
There was a problem hiding this comment.
this one seems can cover it, I am thinking of moving CoversTrait and CoversMethod to phpunit 11 rule tho, but that will be need in separate PR
Member
Author
|
I rolled back remove |
Member
Author
|
Let's merge so we have faster feedback. |
Member
Author
|
Github status is delay https://www.githubstatus.com/ |
auto-merge was automatically disabled
May 22, 2025 08:17
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TimelessTron this should ensure only remove when attribute group added.
Ref rectorphp/rector#9183 (comment)