[phpunit 10] Add ParentTestClassConstructorRector#484
Merged
TomasVotruba merged 4 commits intomainfrom May 5, 2025
Merged
Conversation
72e2da7 to
c1e5d5b
Compare
7572344 to
0fcb26e
Compare
samsonasik
reviewed
May 5, 2025
...sts/PHPUnit100/Rector/Class_/ParentTestClassConstructorRector/Fixture/mocking_helper.php.inc
Show resolved
Hide resolved
eed7ab9 to
132d17c
Compare
be7357e to
1b20777
Compare
Member
Author
|
Let's see how many edge-cases there will be in the wild 🚢 |
Member
|
@TomasVotruba it seems constructor is marked as ref issue : ref phpunit diff sebastianbergmann/phpunit@3263f4c |
Member
|
I created PR: for it. |
Member
|
I created new PHPUnit 12 rule PR for it: to remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BC break in case of non-test
TestCaseclass use, ref sebastianbergmann/phpunit@705874fRef sebastianbergmann/phpunit#3975