Ensure that rule PreferPHPUnitSelfCall refactor call only for static methods, not any#482
Merged
TomasVotruba merged 9 commits intorectorphp:mainfrom May 2, 2025
andrew-demb:make-static-only-static-methods
Merged
Ensure that rule PreferPHPUnitSelfCall refactor call only for static methods, not any#482TomasVotruba merged 9 commits intorectorphp:mainfrom andrew-demb:make-static-only-static-methods
TomasVotruba merged 9 commits intorectorphp:mainfrom
andrew-demb:make-static-only-static-methods
Conversation
Avoid unnecessary resolving
…for static methods, not any rectorphp/rector#9138
samsonasik
reviewed
May 2, 2025
...sts/CodeQuality/Rector/Class_/PreferPHPUnitSelfCallRector/Fixture/include_exceptions.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
May 2, 2025
samsonasik
reviewed
May 2, 2025
...odeQuality/Rector/Class_/PreferPHPUnitSelfCallRector/Fixture/skip_include_exceptions.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
May 2, 2025
...odeQuality/Rector/Class_/PreferPHPUnitSelfCallRector/Fixture/skip_include_exceptions.php.inc
Show resolved
Hide resolved
samsonasik
reviewed
May 2, 2025
… for static call before checking with enum As suggested in review comment #482 (comment)
samsonasik
approved these changes
May 2, 2025
Member
|
I will let @TomasVotruba decide on this ;) |
As suggested in the review comment #482 (comment)
samsonasik
reviewed
May 2, 2025
As of review comment #482 (comment)
samsonasik
approved these changes
May 2, 2025
TomasVotruba
approved these changes
May 2, 2025
Member
|
Awesome work, thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes rectorphp/rector#9138