-
-
Notifications
You must be signed in to change notification settings - Fork 532
fix: remove stale React 18 links #1446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes stale React 18 documentation links that no longer work. The PR description indicates that the URL https://ko-react-exy5xcwjj-fbopensource.vercel.app/ was previously added to link to React 18 Korean documentation but is no longer functional.
Changes:
- Removed React 18 link button from the top navigation bar
- Removed React 18 link button from the home page
- Improved terminology and formatting in documentation (SSG description and code comment formatting)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/Layout/TopNav/TopNav.tsx | Removed the React 18 Korean translation link button from the navigation bar |
| src/components/Layout/HomeContent.js | Removed the React 18 Korean translation link button from the home page |
| src/content/reference/react-dom/static/prerender.md | Improved SSG terminology formatting to include superscript English translation |
| src/content/reference/react-dom/server/renderToString.md | Added backticks around renderToString function name and period in code comment for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Size changesDetails📦 Next.js Bundle Analysis for undefinedThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
|
확인해보니까, 어느 순간부터 Vercel Preview 혹은 Vercel Production이 생성한 임시 URL에 대한 접근이 막혔네요. 현재 한국 ko.react.dev 및 영문 react.dev 사이트 모두 아래와 같은 View Deployment 확인이 안됩니다.
예를 들어, react.dev에서 가장 최근에 생성된 아래 PR에서, View Deployment를 눌러보면, 정상 동작하지 않습니다: @hg-pyun 혹시 시간 되실 때 한번 확인 부탁드려도 될까요? 저만 그런건지 아니면 다들 그런건지 잘 모르겠습니다 😭 |

과거에 React 18 문서로 연결되는
https://ko-react-exy5xcwjj-fbopensource.vercel.app/링크를 추가해두었는데, 해당 링크가 더 이상 동작하지 않아 제거하였습니다.현재 아래와 같은 링크로 연결됩니다:
위 구조는 현재 영문
react.dev웹사이트와 일치합니다.추가로, 문서 상에 존재하는 오탈자 및 오역을 발견하여 수정하였습니다.