Skip to content

fix: prevent dropdown from closing when mousedown on input in multiple mode #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zombieJ merged 3 commits into from
Feb 26, 2026
Merged

fix: prevent dropdown from closing when mousedown on input in multiple mode #1214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0708f78
fix: avoid closing dropdown on input mousedown in multiple mode
QDyanbing Feb 25, 2026
61d253b
chore: simplify input click condition
QDyanbing Feb 25, 2026
9485e8e
refactor: simplify isClickOnInput condition
QDyanbing Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/SelectInput/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,13 +180,21 @@ export default React.forwardRef<SelectInputRef, SelectInputProps>(function Selec
// so we need to mark the event directly
(event.nativeEvent as any)._ori_target = inputDOM;

if (inputDOM && event.target !== inputDOM && !inputDOM.contains(event.target as Node)) {
const isClickOnInput = inputDOM === event.target || inputDOM?.contains(event.target as Node);

if (inputDOM && !isClickOnInput) {
event.preventDefault();
}

// Check if we should prevent closing when clicking on selector
// Don't close if: open && not multiple && (combobox mode || showSearch)
const shouldPreventClose = triggerOpen && !multiple && (mode === 'combobox' || showSearch);
const shouldPreventCloseOnSingle =
triggerOpen && !multiple && (mode === 'combobox' || showSearch);

// Don't close if: open && multiple && click on input
const shouldPreventCloseOnMultipleInput = triggerOpen && multiple && isClickOnInput;

const shouldPreventClose = shouldPreventCloseOnSingle || shouldPreventCloseOnMultipleInput;

if (!(event.nativeEvent as any)._select_lazy) {
inputRef.current?.focus();
Expand Down
17 changes: 17 additions & 0 deletions tests/Multiple.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,5 +712,22 @@ describe('Select.Multiple', () => {
toggleOpen(container);
expect(container.querySelector('input')).toHaveValue('');
});

it('should not close dropdown when mousedown on input in multiple mode (text selection)', () => {
const { container } = render(
<Select mode="multiple" showSearch options={[{ value: 'light' }]} />,
);

const input = container.querySelector('input') as HTMLInputElement;

// Open dropdown first
toggleOpen(container);
expectOpen(container, true);

// Start interaction from input (simulate starting text selection / cursor move)
fireEvent.mouseDown(input);

expectOpen(container, true);
});
});
});
Loading