RFC: fix (?) cross-phase-persistent submodules#37
Open
jesboat wants to merge 1 commit intoracket:masterfrom
Open
RFC: fix (?) cross-phase-persistent submodules#37jesboat wants to merge 1 commit intoracket:masterfrom
jesboat wants to merge 1 commit intoracket:masterfrom
Conversation
Summary:
Previously, errortrace left cross-phase-persistent modules alone, but the check
was not applied to cross-phase-persistent submodules of root modules which were
not themselves cross-phase-persistent. This moves the check inward so it is also
applied to submodules.
Pending: This moves the check from `errortrace-annotate` to
`transform-all-modules` which appears to do the submodule recursion, but which
is also called after `do-annotate` which seems to have some implementations
which also do submodule recursion. I don't understand how these are interacting
and whether the submodule check needs to be earlier, or in both places, or
something. Advice welcome.
Fixes racket/racket/5351.
Test Plan:
Both of these run with
racket -l errortrace -t file.rkt
without error:
```racket
(module outer '#%kernel
(module u '#%kernel
(#%declare #:cross-phase-persistent)))
(module outer '#%kernel
(#%declare #:cross-phase-persistent))
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, errortrace left cross-phase-persistent modules alone, but the check was not applied to cross-phase-persistent submodules of root modules which were not themselves cross-phase-persistent. This moves the check inward so it is also applied to submodules.
Pending: This moves the check from
errortrace-annotatetotransform-all-moduleswhich appears to do the submodule recursion, but which is also called afterdo-annotatewhich seems to have some implementations which also do submodule recursion. I don't understand how these are interacting and whether the submodule check needs to be earlier, or in both places, or something. Advice welcome.Fixes racket/racket#5351
Test Plan:
Both of these run with
without error: