Fix remote fonts not recognised when using a brand extension #13901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new test assertion function that checks regex patterns against CSS files in a document's supporting files directory. This is useful for verifying CSS content that is generated during rendering. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When a brand.yml file with remote font URLs (e.g., https://...) is located in a subfolder (like _extensions/my-brand/), the font URL was incorrectly joined with the path prefix, resulting in broken paths like "_extensions/my-brand/https:/...". Add isExternalPath helper to detect URLs and skip path joining for external font paths. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
It hallucinated Implementation is messy and IIUC just looks for CSS files in output directory - probably should be refined before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13685
brand.ymlare incorrectly treated as file paths when the brand file is in a subfolder (like an extension)isExternalPathhelper to detect URLs (paths starting with a protocol likehttps:) and skip path joining for external font pathsensureCssRegexMatchestest assertion for verifying CSS content in supporting filesTest plan
src:url("https://notofonts.github.io/...)_extensions/my-brand/https:)🤖 Generated with Claude Code