docs: add security implications of annotations#727
Merged
srittau merged 1 commit intopython:mainfrom Jan 28, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #727 +/- ##
=======================================
Coverage 97.38% 97.38%
=======================================
Files 3 3
Lines 7689 7689
=======================================
Hits 7488 7488
Misses 201 201
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
srittau
approved these changes
Jan 28, 2026
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Good to explicitly document this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I received a report alleging that the use of
eval()here is a security vulnerability. There is a caution about this already in the stdlib at https://docs.python.org/3.14/library/annotationlib.html#security-implications-of-introspecting-annotations but I suppose we should put it in the typing-extensions docs too.