Skip to content

Improve MappingPattern rest location #20407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 2 commits into from
Dec 13, 2025
+13 −1
Merged

Improve MappingPattern rest location #20407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5db0753
Improve MappingPattern rest location
cdce8p Dec 13, 2025
e808d9e
explicit type
hauntsaninja Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mypy/fastparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1799,7 +1799,7 @@ def visit_MatchMapping(self, n: ast3.MatchMapping) -> MappingPattern:
if n.rest is None:
rest = None
else:
rest = NameExpr(n.rest)
rest = self.set_line(NameExpr(n.rest), n)

node = MappingPattern(keys, values, rest)
return self.set_line(node, n)
Expand Down
12 changes: 12 additions & 0 deletions test-data/unit/check-python310.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3194,3 +3194,15 @@ def fun(val: str | None):
case types.NoneType():
reveal_type(val) # N: Revealed type is "None"
[builtins fixtures/tuple.pyi]

[case testMatchMappingRestErrorLocation]
rest: list[int]
data: list[int]
match data:
case [1, *rest]:
...
config: dict[str, object]
match config:
case {"a": 1, **rest}: # E: Incompatible types in capture pattern (pattern captures type "dict[str, object]", variable has type "list[int]")
...
[builtins fixtures/dict.pyi]