gh-144307: fix refcount leak in finalize_remove_modules()
#144308
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PyIter_Next()` returns a new reference, but `finalize_remove_modules()` failed to DECREF `key` when `PyObject_GetItem()`` returns NULL. Fix by DECREF'ing `key` before continuing. Signed-off-by: Yongtao Huang <yongtaoh2022@gamil.com>
hyongtao-code
requested review from
ZeroIntensity and
ericsnowcurrently
as code owners
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
This is user-facing so it needs a news entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyIter_Next()returns a new reference, butfinalize_remove_modules()failed to DECREFkeywhenPyObject_GetItem()returns NULL. Fix by DECREF'ingkeybefore continuing.finalize_remove_modules()#144307