Skip to content

gh-141004: Don't trigger run-tests when Tools/check-c-api-docs/ignored_c_api.txt is changed #143583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StanFromIreland wants to merge 4 commits into
base: main
Choose a base branch
from
+8 −10
Open

gh-141004: Don't trigger run-tests when Tools/check-c-api-docs/ignored_c_api.txt is changed #143583

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9d85cd
Stop changes to Tools/check-c-api-docs/ignored_c_api.txt triggering r…
StanFromIreland Jan 8, 2026
ba9156f
Merge sets as req by Peter
StanFromIreland Jan 9, 2026
8f886b5
Oneline
StanFromIreland Jan 9, 2026
a8ae13a
Improve condition
StanFromIreland Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions Tools/build/compute-changes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,16 @@
from collections.abc import Set

GITHUB_DEFAULT_BRANCH = os.environ["GITHUB_DEFAULT_BRANCH"]
GITHUB_CODEOWNERS_PATH = Path(".github/CODEOWNERS")
GITHUB_WORKFLOWS_PATH = Path(".github/workflows")

CONFIGURATION_FILE_NAMES = frozenset({
".pre-commit-config.yaml",
".ruff.toml",
"mypy.ini",
RUN_TESTS_IGNORE = frozenset({
Path("Tools/check-c-api-docs/ignored_c_api.txt"),
Path(".github/CODEOWNERS"),
Path(".pre-commit-config.yaml"),
Path(".ruff.toml"),
Comment on lines +26 to +28
Copy link
Member

@ZeroIntensity ZeroIntensity Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth keeping CONFIGURATION_FILE_NAMES and just flattening it here, but I'm not going to block the PR on it.

Path("mypy.ini"),
})

UNIX_BUILD_SYSTEM_FILE_NAMES = frozenset({
Path("aclocal.m4"),
Path("config.guess"),
Expand Down Expand Up @@ -172,11 +174,7 @@ def process_changed_files(changed_files: Set[Path]) -> Outputs:
if file.name == "reusable-wasi.yml":
platforms_changed.add("wasi")

if not (
doc_file
or file == GITHUB_CODEOWNERS_PATH
or file.name in CONFIGURATION_FILE_NAMES
):
if not doc_file and file not in RUN_TESTS_IGNORE:
run_tests = True

platform = get_file_platform(file)
Expand Down
Loading