-
-
Notifications
You must be signed in to change notification settings - Fork 34k
gh-142903: add conda-forge license for pixi-packages #143468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
vstinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Could you word-wrap to match https://github.com/conda-forge/python-feedstock/blob/main/LICENSE.txt (and to make this readable without scrolling)? |
|
done |
|
You need to update your branch to fix the CI. |
|
out of interest, is the 'update branch' button not available to maintainers too? |
|
It is, I just don't want to cause you any trouble if you have local changes :-) |
|
should be good to go @encukou |
Doc/license.rst
Outdated
| license:: | ||
|
|
||
| BSD-3-Clause license | ||
| Copyright (c) 2015-2022, conda-forge contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to proactively pick up the changes from conda-forge/conda-smithy#2458 here
| Copyright (c) 2015-2022, conda-forge contributors | |
| Copyright (c) 2015-2026, conda-forge contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, wait, that's for the conda-smithy repo. Will it get copied to python-feedstock?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conda-smithy is the main tool for taking care of feedstocks. It defines how feedstocks are updated ("rerendered"), and defines the baseline of what those feedstocks are made of (that's why that file is in a folder called feedstock_contents). As soon as a new smithy version is released (usually every couple of weeks), all feedstocks will get an updated copyright year in the course of regular maintenance.
Speaking as someone from cf/core, it was only due to a simple oversight that the copyright year wasn't updated. I can even push this change to the python feedstock manually if that makes you happy. 🙃
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
cc @AA-Turner @isuruf
📚 Documentation preview 📚: https://cpython-previews--143468.org.readthedocs.build/