Skip to content

Conversation

@lucascolley
Copy link
Contributor

@lucascolley lucascolley commented Jan 6, 2026

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@encukou
Copy link
Member

encukou commented Feb 3, 2026

Could you word-wrap to match https://github.com/conda-forge/python-feedstock/blob/main/LICENSE.txt (and to make this readable without scrolling)?

@lucascolley
Copy link
Contributor Author

done

@StanFromIreland
Copy link
Member

You need to update your branch to fix the CI.

@lucascolley
Copy link
Contributor Author

out of interest, is the 'update branch' button not available to maintainers too?

@StanFromIreland
Copy link
Member

It is, I just don't want to cause you any trouble if you have local changes :-)

@lucascolley
Copy link
Contributor Author

should be good to go @encukou

Doc/license.rst Outdated
license::

BSD-3-Clause license
Copyright (c) 2015-2022, conda-forge contributors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to proactively pick up the changes from conda-forge/conda-smithy#2458 here

Suggested change
Copyright (c) 2015-2022, conda-forge contributors
Copyright (c) 2015-2026, conda-forge contributors

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wait, that's for the conda-smithy repo. Will it get copied to python-feedstock?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conda-smithy is the main tool for taking care of feedstocks. It defines how feedstocks are updated ("rerendered"), and defines the baseline of what those feedstocks are made of (that's why that file is in a folder called feedstock_contents). As soon as a new smithy version is released (usually every couple of weeks), all feedstocks will get an updated copyright year in the course of regular maintenance.

Speaking as someone from cf/core, it was only due to a simple oversight that the copyright year wasn't updated. I can even push this change to the python feedstock manually if that makes you happy. 🙃

Co-authored-by: h-vetinari <h.vetinari@gmx.com>
@AA-Turner AA-Turner merged commit 0bb4eca into python:main Feb 4, 2026
29 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants