-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
gh-143181: Fix 'overriden' -> 'overridden' in c-api/module.rst #143182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There's some "overriden" in test comments, want to fix them too? Also, no need to create an issue next time for trivial things like typo fixes. https://devguide.python.org/getting-started/pull-request-lifecycle/#id2 |
StanFromIreland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Need case-sensitive search to no match |
|
Terry, here is a case-insensitive grep: |
a7063df to
8b4c5ef
Compare
|
Changed "overriden" -> "overridden" in the tests. Class names like OverrideNew and OverrideNeither were already spelled correctly with "Override", so they didn't need changing. |
|
My apologies, I meant case-sensitive to avoid fake hits. |
|
Thanks @duane9 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @duane9 and @terryjreedy, I could not cleanly backport this to |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
The doc is not in 3.14. As I noted above, the tests are, but they also are not in 3.13. |
|
I tried the 3.14 cherry_picker fix but I don't understand how to fix the merge conflict here. Might be simpler to start fresh. I'll leave for someone else or we can not backport. Not essential here. |
|
If one were to open a PR that fixes just typos in tests we would generally reject it, I think we should apply the same logic to the backport. |
Doc/c-api/module.rst line 574:
📚 Documentation preview 📚: https://cpython-previews--143182.org.readthedocs.build/