Skip to content

Conversation

@duane9
Copy link
Contributor

@duane9 duane9 commented Dec 26, 2025

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Dec 26, 2025
@python-cla-bot
Copy link

python-cla-bot bot commented Dec 26, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@hugovk
Copy link
Member

hugovk commented Dec 26, 2025

There's some "overriden" in test comments, want to fix them too?

Also, no need to create an issue next time for trivial things like typo fixes.

https://devguide.python.org/getting-started/pull-request-lifecycle/#id2

Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terryjreedy terryjreedy changed the title gh-143181: Fix typo 'overriden' -> 'overridden' in c-api/module.rst gh-143181: Fix 'overriden' -> 'overridden' in c-api/module.rst Dec 26, 2025
@terryjreedy
Copy link
Member

Searching 'overriden' in C:\Programs\Python315\Lib\test\*.py ...
C:\Programs\Python315\Lib\test\test_build_details.py: 36:         """Install details file contents. Should be overriden by subclasses."""
C:\Programs\Python315\Lib\test\test_dict.py: 1584:         # Only TypeError exception is overriden,
C:\Programs\Python315\Lib\test\test_set.py: 664:         # Only TypeError exception is overriden,

Need case-sensitive search to no match OverrideN....
Same in 3.14, not in 3.13. Likely new errors since last general spell check.

@duane9 duane9 requested a review from FFY00 as a code owner December 26, 2025 22:34
@StanFromIreland
Copy link
Member

StanFromIreland commented Dec 26, 2025

Terry, here is a case-insensitive grep:

$ git grep -ri overriden
Doc/c-api/module.rst:  hook returned (unless overriden with :c:macro:`Py_mod_token`).
Lib/test/test_build_details.py:        """Install details file contents. Should be overriden by subclasses."""
Lib/test/test_descr.py:        class OverrideNeither:
Lib/test/test_descr.py:        self.assertRaises(TypeError, OverrideNeither, 1)
Lib/test/test_descr.py:        self.assertRaises(TypeError, OverrideNeither, kw=1)
Lib/test/test_descr.py:        class OverrideNew:
Lib/test/test_descr.py:        class OverrideBoth(OverrideNew, OverrideInit):
Lib/test/test_descr.py:        for case in OverrideNew, OverrideInit, OverrideBoth:
Lib/test/test_dict.py:        # Only TypeError exception is overriden,
Lib/test/test_set.py:        # Only TypeError exception is overriden,

@duane9 duane9 force-pushed the fix-overridden-typo branch from a7063df to 8b4c5ef Compare December 26, 2025 22:37
@duane9
Copy link
Contributor Author

duane9 commented Dec 26, 2025

Changed "overriden" -> "overridden" in the tests. Class names like OverrideNew and OverrideNeither were already spelled correctly with "Override", so they didn't need changing.

@terryjreedy
Copy link
Member

My apologies, I meant case-sensitive to avoid fake hits.

@terryjreedy terryjreedy merged commit 5d1e78f into python:main Dec 27, 2025
46 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Dec 27, 2025
@terryjreedy terryjreedy added the needs backport to 3.14 bugs and security fixes label Dec 27, 2025
@miss-islington-app
Copy link

Thanks @duane9 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @duane9 and @terryjreedy, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5d1e78f7b59ffa3308755b5b2e0f85eb0c6ac890 3.14

@hugovk hugovk added the needs backport to 3.13 bugs and security fixes label Dec 27, 2025
@miss-islington-app

This comment was marked as outdated.

@miss-islington-app

This comment was marked as outdated.

@terryjreedy
Copy link
Member

The doc is not in 3.14. As I noted above, the tests are, but they also are not in 3.13.

@hugovk hugovk removed the needs backport to 3.13 bugs and security fixes label Dec 27, 2025
@terryjreedy
Copy link
Member

I tried the 3.14 cherry_picker fix but I don't understand how to fix the merge conflict here. Might be simpler to start fresh. I'll leave for someone else or we can not backport. Not essential here.

@StanFromIreland
Copy link
Member

StanFromIreland commented Dec 27, 2025

If one were to open a PR that fixes just typos in tests we would generally reject it, I think we should apply the same logic to the backport.

@StanFromIreland StanFromIreland removed the needs backport to 3.14 bugs and security fixes label Dec 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants