[3.10] gh-130577: tarfile now validates archives to ensure member offsets are non-negative (GH-137027)

[gpshead]

(cherry picked from commit 7040aa5)

• Issue: tarfile.StreamError: seeking backwards is not allowed due to unskipped block with bad checksum #130577

[mgorny]

This seems to have been mistakenly added in a merge error.

[mcepl]

I don't think this can ever work … there is no test.archiver_test module in 3.10. It came with the solution for #114959 which has never been backported to 3.10 or lower.

[mgorny]

Sure, but OverwriteTests are not even a part of 7040aa5.

[mgorny]

In case this helps:

Suggested change

	class OverwriteTests(archiver_tests.OverwriteTests, unittest.TestCase):
	testdir = os.path.join(TEMPDIR, "testoverwrite")
	@classmethod
	def setUpClass(cls):
	p = cls.ar_with_file = os.path.join(TEMPDIR, 'tar-with-file.tar')
	cls.addClassCleanup(os_helper.unlink, p)
	with tarfile.open(p, 'w') as tar:
	t = tarfile.TarInfo('test')
	t.size = 10
	tar.addfile(t, io.BytesIO(b'newcontent'))
	p = cls.ar_with_dir = os.path.join(TEMPDIR, 'tar-with-dir.tar')
	cls.addClassCleanup(os_helper.unlink, p)
	with tarfile.open(p, 'w') as tar:
	tar.addfile(tar.gettarinfo(os.curdir, 'test'))
	p = os.path.join(TEMPDIR, 'tar-with-implicit-dir.tar')
	cls.ar_with_implicit_dir = p
	cls.addClassCleanup(os_helper.unlink, p)
	with tarfile.open(p, 'w') as tar:
	t = tarfile.TarInfo('test/file')
	t.size = 10
	tar.addfile(t, io.BytesIO(b'newcontent'))
	def open(self, path):
	return tarfile.open(path, 'r')
	def extractall(self, ar):
	ar.extractall(self.testdir, filter='fully_trusted')

[vstinner]

Alternative backport without the OverwriteTests class: #137644

[encukou]

The alternative was merged.