trio_websocket/_impl.py: Don't reply to pings on a locally closed connection#198
Open
geronimogoemon wants to merge 1 commit intopython-trio:masterfrom
Open
trio_websocket/_impl.py: Don't reply to pings on a locally closed connection#198geronimogoemon wants to merge 1 commit intopython-trio:masterfrom
geronimogoemon wants to merge 1 commit intopython-trio:masterfrom
Conversation
belm0
reviewed
Mar 29, 2025
Member
There was a problem hiding this comment.
thank you-- would you mind trying to add unit test coverage for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered this issue in my application and applied the following fix in my local fork. I am making the PR in case there is interest in applying this fix on the main repo.
For clarity, the source of the problem seems to be the fact that when calling
aclose()we will send aCloseConnectionmessage here and then allow context switch on await before we disable processing of incoming messages here but after wsproto will change its connection state toLOCAL_CLOSING. During that time gap we can receive Ping message which will result in exception upon handling it.Fixes #184