Add the ability to specify the buffer size.#186
Merged
CoolCat467 merged 6 commits intopython-trio:masterfrom Jan 31, 2025
Merged
Add the ability to specify the buffer size.#186CoolCat467 merged 6 commits intopython-trio:masterfrom
CoolCat467 merged 6 commits intopython-trio:masterfrom
Conversation
belm0
reviewed
Nov 17, 2023
Author
|
Thanks for the comments, it definitely didn't make sense not to propagate it... Now I forward it everywhere, so this PR should be good to go I hope :) (I still have an open question on the old one, I still don't really understand what the drawback/risk of increasing the default size is, to be honest. But as you want.) |
CoolCat467
approved these changes
Jan 13, 2025
Member
CoolCat467
left a comment
CoolCat467
left a comment
There was a problem hiding this comment.
Looks good as far as I can tell
belm0
approved these changes
Jan 14, 2025
trio_websocket/_impl.py
Outdated
Comment on lines
97
to
109
| host: str, | ||
| port: int, | ||
| resource: str, | ||
| *, | ||
| use_ssl: Union[bool, ssl.SSLContext], | ||
| subprotocols: Optional[Iterable[str]] = None, | ||
| extra_headers: Optional[list[tuple[bytes,bytes]]] = None, | ||
| message_queue_size: int = MESSAGE_QUEUE_SIZE, | ||
| max_message_size: int = MAX_MESSAGE_SIZE, | ||
| receive_buffer_size: int = RECEIVE_BYTES, | ||
| connect_timeout: float = CONN_TIMEOUT, | ||
| disconnect_timeout: float = CONN_TIMEOUT | ||
| ): |
Member
There was a problem hiding this comment.
I'd prefer to avoid the reformatting in this PR
Contributor
There was a problem hiding this comment.
Given the type hint PR did all the reformatting this no longer is reformatted (heh).
belm0
approved these changes
Jan 31, 2025
belm0
pushed a commit
that referenced
this pull request
Feb 16, 2025
Co-authored-by: CoolCat467 <52022020+CoolCat467@users.noreply.github.com> Co-authored-by: A5rocks <git@helvetica.moe>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See this PR for context: #185