-
Notifications
You must be signed in to change notification settings - Fork 55
[RTR] Holonomic muscle model #1024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Ipuch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ipuch reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @p-shg)
bioptim/examples/holonomic_constraints/arm26_pendulum_swingup_Muscle_algebraic.py line 1 at r1 (raw file):
"""
"muscle_algebraic.py"
bioptim/examples/holonomic_constraints/four_bar.py line 1 at r1 (raw file):
"""
add the test somewhere.
bioptim/examples/holonomic_constraints/custom_dynamics.py line 166 at r1 (raw file):
class HolonomicMusclesDynamics(HolonomicTorqueDynamics):
put everything in custom_dynamics_muscle.py, copy paste or import from the other file.
bioptim/examples/holonomic_constraints/arm26_pendulum_swingup.py line 1 at r1 (raw file):
"""
Not necessary
bioptim/examples/holonomic_constraints/arm26_pendulum_swingup_Muscle.py line 1 at r1 (raw file):
"""
name of the file "_muscle.py"
Specifically using more objects, or more than one constraint, on different objects or on the same object pair. This should help newer users of holonomic constraints understand this better
Specifically using more objects, or more than one constraint, on different objects or on the same object pair. This should help newer users of holonomic constraints understand this better
TODO add tests
All Submissions:
New Feature Submissions:
black . -l120 --exclude "external/*")?Changes to Core Features:
Working on Muscle driven dynamics for models with holonomic constraints
@pariterre the arm26_pendulum_swingup_Muscle_algebraic.py file reproduces the plotting error I told you about
This change is