Use uuid, it speeds up the call#4786
Use uuid, it speeds up the call#4786yuval-peleg-levy-ai21 wants to merge 1 commit intopymupdf:mainfrom
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
I've reviewed your proposal, but I don't believe it addresses a significant performance concern. Our current implementation achieves durations in the low single-digit microsecond range — even with name lists of around 20 entries, which is itself uncommon. When using a set() for containment checks, performance nearly doubles and matches or exceeds that of a UUID-based approach when the list size is 10 or fewer — the most typical case. Additionally, the current naming strategy produces short and readable identifiers in contrast to UUIDs like 'b58cb87d-50a0-4ae2-be88-77ea77afdb0d'. Given these factors, we’ll stick with the existing solution and ensure we will use the |
|
Hey, I did this after seeing these calls are a bottlenck using a profiler. Thanks! |
|
Ah, now I understand your motivation better! |
|
Thanks. Sorry for not being more detailed in my PR. |
Use uuid, it speeds up the call