temporarily silence shape assignment warnings raised in netCDF4#11146
Merged
keewis merged 8 commits intopydata:mainfrom Feb 11, 2026
Merged
temporarily silence shape assignment warnings raised in netCDF4#11146keewis merged 8 commits intopydata:mainfrom
netCDF4#11146keewis merged 8 commits intopydata:mainfrom
Conversation
jsignell
approved these changes
Feb 10, 2026
Member
jsignell
left a comment
There was a problem hiding this comment.
Gross but good catch! It looks like there is another assignment like this in _copy_with_dtype
Collaborator
Author
|
I might have totally misunderstood what they deprecated. It appears that was Edit: see Unidata/netcdf4-python#1468 |
df47fa2 to
269f868
Compare
Collaborator
Author
|
should be good for another round of reviews (I'm not at all sure this is the best way to ignore the warning) and merging |
dcherian
approved these changes
Feb 11, 2026
netCDF4
Collaborator
Author
|
let's merge, then! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently,
numpyhas decided to deprecate assignments likex[...] = y. We can replace this with