-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Refactor cache-pixi-lock.yml workflow into external action
#11096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
keewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
took me a while to review, but I agree that we don't need to wait on this to be moved outside the parcels org.
I've gone ahead and changed the job dependency chains (there's no need to resolve environments if we skip ci, anyways), and also simplified some trigger conditions. As such I won't approve (as in, the github review reaction), but as far as I can see this looks good to me.
c910a87 to
e355df9
Compare
It appears the addition of `osx-64` causes `pixi` to need more resources (it keeps getting killed).
Refactors the workflow to https://github.com/Parcels-code/pixi-lock - outside the Xarray repo so that it can be used in
other projects.
Prefix devs expressed interest in their Discord about maintaining the action, but that's
undecided at the moment
(context).
Either way, I don't think its a blocker (once the repo is transfered, either to
prefix-devorxarray-contrib, the existing links will still work via GHs repo moving symlink behaviour )Updated the runner for the caching to use
ubuntu-slimas they start quicker, and most hits will just be restoring the cache file anyway.cc @keewis