Skip to content

Fix deadlock in test with free threading #5973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colesbury wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −4
Open

Fix deadlock in test with free threading #5973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions tests/test_with_catch/test_subinterpreter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,15 +501,21 @@ TEST_CASE("Per-Subinterpreter GIL") {

// wait for something to set sync to our thread number
// we are holding our subinterpreter's GIL
while (sync != num)
std::this_thread::sleep_for(std::chrono::microseconds(1));
{
py::gil_scoped_release nogil;
while (sync != num)
std::this_thread::sleep_for(std::chrono::microseconds(1));
}

// now change it so the next thread can move on
++sync;

// but keep holding the GIL until after the next thread moves on as well
while (sync == num + 1)
std::this_thread::sleep_for(std::chrono::microseconds(1));
{
py::gil_scoped_release nogil;
while (sync == num + 1)
std::this_thread::sleep_for(std::chrono::microseconds(1));
}

// one last check before quitting the thread, the internals should be different
auto sub_int
Expand Down
Loading