Add throwing callable wrapper #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `try!` with do/catch in PythonObject.dynamicallyCall methods. Previously, any Python exception raised during dynamic calls would trigger swift_unexpectedError → SIGTRAP, crashing the app. Now returns Python.None with assertionFailure (debug-only) instead of fatal crash in release builds. Affected methods: - dynamicallyCall(withArguments:) - dynamicallyCall(withKeywordArguments:) (both overloads)
…lls" This reverts commit ee2baf2.
Add `safeCallable` property to PythonObject that returns Python.None on Python exceptions instead of crashing. Follows the existing `throwingCallable` pattern, providing an opt-in safe path without changing default behavior. Usage: obj.safeCallable(args...) → returns Python.None on error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new way to call Python functions from Swift that surfaces Python exceptions as Swift errors, rather than trapping. This allows developers to handle Python errors using Swift's
try/catchmechanism, making error handling more robust and idiomatic in Swift. The changes include a new wrapper type, an extension property for easier access, and corresponding unit tests.New error-handling callable support:
throwingCallableproperty toPythonObject, which returns aThrowingDynamicCallablewrapper. This allows users to opt-in to error handling viatry/catchwhen calling Python functions from Swift.ThrowingDynamicCallablestruct, a dynamic-callable wrapper aroundPythonObjectthat throws Swift errors when Python exceptions are raised, instead of trapping. This struct provides severaldynamicallyCallmethods for calling Python functions with positional or keyword arguments.Testing:
testThrowingCallableWrapper, to verify thatthrowingCallablecorrectly returns results for valid calls and throws Swift errors for Python exceptions, including checking the exception type.