Remove unused before block from unit tests#1539
Open
bastelfreak wants to merge 1 commit intopuppetlabs:mainfrom
Open
Remove unused before block from unit tests#1539bastelfreak wants to merge 1 commit intopuppetlabs:mainfrom
bastelfreak wants to merge 1 commit intopuppetlabs:mainfrom
Conversation
bastelfreak
requested review from
a team,
SimonHoenscheid,
alexjfisher,
deric,
ekohl and
smortex
as code owners
ekohl
reviewed
Oct 19, 2023
Collaborator
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I'm not sure if these really are unused. I'd think they prevent accidentally reading the real file system.
Perhaps it would be better to replace read and write with .and_raise_error('Unexpected file access').
bastelfreak
force-pushed
the
cleanup2
branch
from
4f55281 to
5039888
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)