Allow multiple searches on single URLs #58
+450
−284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a new `multiTrigger` option in the configuration to allow users to specify multiple search triggers. - Updated the `getRedirects` function to handle both single and multi-trigger scenarios. - Included OptionsTabPanel in UI for setting the multi-trigger, with validation to prevent conflicts with the standard trigger.
Owner
|
Sorry I've been busy, will try to look at this soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #54
Added multi-trigger that allows to have multiple searches at one bang
By default uses
!!trigger to activate multi search. In issue discussion was suggested to use:I thought that adding toggle to every option will result in clattered UI. My solution proposes to have a new optional and configurable trigger (by default
!!). So by searching!!g cat dogit will open 2 tabs for two searches.About question:
I decided to add possibility of searching multiple words inside
[], for example:!g [hello world] hello worldwill result in 3 tabs forhello world,helloandworldsearcher.By default
Multi Triggeris turned off and can be modified (added validation, so it can not be same as regular trigger), multiple words search is turned on.Code is tested in Chrome and Firefox. I hope PR was done correctly, if not, happy to rewrite and fix issues as needed
//btw, thanks for your incredible extension