Skip to content

Apply review feedback: rename confirmButtonRef and add Storybook args support#7522

Merged
francinelucca merged 3 commits intochore/fix-max-height-attributesfrom
copilot/sub-pr-7510
Feb 11, 2026
Merged

Apply review feedback: rename confirmButtonRef and add Storybook args support#7522
francinelucca merged 3 commits intochore/fix-max-height-attributesfrom
copilot/sub-pr-7510

Conversation

Copy link
Contributor

Copilot AI commented Feb 10, 2026

Addresses review feedback from PR #7510 to improve the SettingMaxHeight story implementation for better clarity and e2e/VRT test compatibility.

Changelog

Changed

  • Renamed confirmButtonRef to closeButtonRef in SettingMaxHeight story to accurately reflect the element it references
  • Updated SettingMaxHeight story to accept Storybook Args parameter, enabling e2e/VRT tests to control overlay state via args: {open: true}
  • Updated render condition to isOpen || open to support both internal state and Storybook args
  • Updated useFocusTrap disabled condition to !isOpen && !open to match render logic

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Story now follows the same pattern as DialogOverlay and DropdownOverlay for args handling. Verify the story renders correctly in Storybook with args: {open: true}.

SettingMaxHeight Story

Merge checklist


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2026

⚠️ No Changeset found

Latest commit: 9a1939f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix max-height exceeding viewport height in Overlay and ActionMenu Apply review feedback: rename confirmButtonRef and add Storybook args support Feb 10, 2026
Copilot AI requested a review from francinelucca February 10, 2026 19:02
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 11, 2026
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@francinelucca francinelucca added update snapshots 🤖 Command that updates VRT snapshots on the pull request skip changeset This change does not need a changelog and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Feb 11, 2026
@github-actions github-actions bot temporarily deployed to storybook-preview-7522 February 11, 2026 00:46 Inactive
@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Feb 11, 2026
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@francinelucca francinelucca marked this pull request as ready for review February 11, 2026 01:03
@francinelucca francinelucca requested review from a team as code owners February 11, 2026 01:03
@francinelucca francinelucca merged commit d2652cb into chore/fix-max-height-attributes Feb 11, 2026
46 checks passed
@francinelucca francinelucca deleted the copilot/sub-pr-7510 branch February 11, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants