Apply review feedback: rename confirmButtonRef and add Storybook args support#7522
Conversation
|
Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
d2652cb
into
chore/fix-max-height-attributes
Addresses review feedback from PR #7510 to improve the
SettingMaxHeightstory implementation for better clarity and e2e/VRT test compatibility.Changelog
Changed
confirmButtonReftocloseButtonRefinSettingMaxHeightstory to accurately reflect the element it referencesSettingMaxHeightstory to accept StorybookArgsparameter, enabling e2e/VRT tests to control overlay state viaargs: {open: true}isOpen || opento support both internal state and Storybook argsuseFocusTrapdisabled condition to!isOpen && !opento match render logicRollout strategy
Testing & Reviewing
Story now follows the same pattern as
DialogOverlayandDropdownOverlayfor args handling. Verify the story renders correctly in Storybook withargs: {open: true}.Merge checklist
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.