Apply review feedback: fix initialFocusRef, positioning, and mobile viewport handling#7519
Conversation
|
…e 100dvh Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
42f47e8
into
chore/fix-max-height-attributes
Addresses technical debt from PR #7510 review comments: corrects focus management, CSS positioning, and mobile Safari viewport calculations.
Changelog
Changed
Overlay.module.cssandActionMenu.module.css: Replace100vhwith100dvhin max-height calculations to prevent clipping behind mobile browser chromeOverlay.features.stories.tsx: AttachconfirmButtonRefto close button for proper initial focus behaviorOverlay.features.stories.module.css: Addposition: relativeto.ScrollableContentto establish containing block for absolutely positioned close buttonRollout strategy
Testing & Reviewing
Storybook "SettingMaxHeight" example validates focus trap and scrollable content behavior. Mobile Safari testing confirms overlays no longer clip behind browser UI.
Merge checklist
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.