Refactor Breadcrumb to be more SSR friendly#7502
Draft
Conversation
🦋 Changeset detectedLatest commit: 12c1d30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
Breadcrumb to be more SSR friendly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the Breadcrumbs component to extract responsive overflow logic into a standalone hook (
useBreadcrumbsResponsive) and separate overflow menu component, improving code organization and enabling SSR-friendly usage patterns.Changelog
Changed
Refactor: Extract responsive breadcrumbs logic
useBreadcrumbsResponsivehook - Encapsulates all overflow calculation logic (resize observation, width measurements, visibility state) into a reusable hook that can be used independently for customimplementations
BreadcrumbsOverflowMenucomponent - Extracts the overflow menu dropdown into a standalone componentresponsiveprop to Breadcrumbs - allows opting out of automatic overflow handling for manual controluseBreadcrumbsResponsivefrom the package for consumers who need SSR-friendly conditional renderingFix: Prevent overflow during SSR
overflow: hiddento breadcrumbs container with menu or menu-with-root overflow modes to prevent content from overflowing before JavaScript calculates the overflow menuRollout strategy
Testing & Reviewing
Merge checklist