fix(orderlist): preserve original order when moving multi-selected items #8497
Conversation
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
2 similar comments
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
Coderxrohan
force-pushed
the
fix/orderlist-multiselect-order
branch
from
bd667c8 to
e0b5e6e
Compare
|
Fixed: 8497.mp4 |
|
Hi @melloware,
The fix simply sorts selected items by their original list index before reorder actions — no API changes. |
|
/assign me |
|
@melloware, ready to merge! |
| if (metaKey) { | ||
| const merged = [...selectionState, value]; | ||
|
|
||
| newSelection = merged.sort((a, b) => props.value.indexOf(a) - props.value.indexOf(b)); |
There was a problem hiding this comment.
SHould we check if props.value is not undefined or null or else this will error? I didn't look at the rest of the code so not sure its even possible
There was a problem hiding this comment.
Suggested changes applied. Please take a look. Thanks!
|
Added a small defensive fallback for |
2 participants
Defect Fix
This PR addresses a multi-selection ordering issue in OrderList where items selected out of sequence (e.g., Ctrl-click) were reordered incorrectly when moved to the top or bottom.
Summary of changes:
Normalize multi-selection by sorting selected items based on their original list index before reorder operations.
Ensures selected items always retain their visual order regardless of selection sequence.
Notes
This is a focused UX bug fix with no API changes.
Only components/orderlist/OrderList.js is affected.
Behavior now matches user expectations and native list reordering patterns.
Fixes: #8496
Fixed:#8496
Fixes: #8495
Fixed:#8495
(Duplicate due to ci error)