Skip to content

Conversation

@jkebinger
Copy link
Contributor

Version 0.12.1

This release includes the InternalLogger fix that enables proper logging visibility.

Changes

🐛 Bug Fixes

  • Fixed InternalLogger to properly register with logging hierarchy (Fix InternalLogger to properly register with logging hierarchy #127)
    • InternalLogger instances now register with Python's logging manager
    • Handlers properly propagate from parent loggers
    • logging.basicConfig() now works correctly
    • Compatible with both standard logging and structlog
    • Maintains prefab_internal=True extra attribute on log records

🔧 Other Changes

  • Fixed CODEOWNERS file formatting (added missing trailing newline)

Impact

Users can now see Prefab's internal logs (config loading, checkpoint updates, SSE connections, etc.) using standard Python logging configuration, without manual workarounds.

Testing

The InternalLogger fix has been tested with:

  • ✅ Standard logging (logging.basicConfig)
  • ✅ Structlog integration
  • ✅ Handler propagation through logger hierarchy
  • prefab_internal extra attribute preservation

@jkebinger jkebinger requested a review from a team as a code owner November 20, 2025 16:21
Copy link
Contributor

@jdwyah jdwyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@jkebinger jkebinger merged commit 23e9c3d into main Nov 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants