Add envId field to Match metadata #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an Optional<Long> envId field to the Match class that reports the environment ID of the ConfigRow that matched. The field is empty for default environment rows that don't have a project_env_id set. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
jkebinger
added a commit
to ReforgeHQ/sdk-java
that referenced
this pull request
Oct 8, 2025
Adds an Optional<Long> envId field to the Match class that reports the environment ID of the ConfigRow that matched during config evaluation. This allows consumers to know which environment's configuration was used. Changes: - Add envId field to Match class with getter - Update ConfigRuleEvaluator to extract project_env_id from ConfigRow - Update ConfigResolver to preserve envId when reifying matches - Update test files to include envId parameter in Match constructors Ported from prefab-cloud/prefab-cloud-java#154 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
2 tasks
jkebinger
added a commit
to ReforgeHQ/sdk-java
that referenced
this pull request
Oct 8, 2025
Adds an Optional<Long> envId field to the Match class that reports the environment ID of the ConfigRow that matched during config evaluation. This allows consumers to know which environment's configuration was used. Changes: - Add envId field to Match class with getter - Update ConfigRuleEvaluator to extract project_env_id from ConfigRow - Update ConfigResolver to preserve envId when reifying matches - Update test files to include envId parameter in Match constructors Ported from prefab-cloud/prefab-cloud-java#154 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
Optional<Long> envIdfield to theMatchclass that reports the environment ID of theConfigRowthat matched during config evaluation.Changes
envIdfield toMatchclass with getter methodConfigRuleEvaluatorto extract and pass theproject_env_idfrom matchedConfigRowConfigResolverto preserveenvIdwhen reifying matchesenvIdparameter inMatchconstructor callsDetails
The
envIdfield isOptional<Long>because theproject_env_idfield inConfigRowis optional - it's only populated for environment-specific rows, not for default environment rows.All 428 tests pass successfully.
🤖 Generated with Claude Code