Skip to content

Conversation

@SuperIzya
Copy link
Contributor

@SuperIzya SuperIzya commented Nov 12, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?


float treatmentRate;

List<String> targetBidders;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperIzya , you might want to have this and other configs to be per-account, instead of being global. Or being overridable by the account. Right now, big host companies that serve multiple accounts won't be able to define different configs for different accounts. Which doesn't sound like something that you actually want.

No need to implement this in the scope of this PR. It's just a thing for you to think about.

@Net-burst Net-burst requested a review from osulzhenko November 14, 2025 17:58
@osulzhenko osulzhenko requested a review from CTMBNara November 17, 2025 15:34
@Net-burst Net-burst changed the title DATA-43462: Limiting LI ids to bidders LiveIntent: Limiting LI ids to configured bidders Nov 17, 2025
Copy link
Collaborator

@CTMBNara CTMBNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add unit tests

@CTMBNara CTMBNara merged commit 3cb039b into prebid:master Nov 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants