Merged
Conversation
marvinhagemeister
approved these changes
Feb 21, 2025
JoviDeCroock
approved these changes
Feb 21, 2025
Member
Author
|
Do we want newlines? Our editor config disables those for Lines 10 to 13 in 2a788d6 Will check with biome shortly, not sure what it enforces by default Edit: Our editorconfig & biome settings were indeed conflicting, I edited the editor config as most of our other files were missing line endings so it makes sense to match biome. |
6569395 to
61d15bb
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #4629, should be much safer.
Basic gist is that
require(esm)seemingly begins to parse modules to determine whether it's CJS or ESM, and in the case of the latter, require hooks are not yet supported against ESM modules so Babel doesn't transform the JSX within.From Joyee's blog:
https://joyeecheung.github.io/blog/2024/03/18/require-esm-in-node-js/