Mark all non-static declarations as internal or external by hanno-becker · Pull Request #951 · pq-code-package/mldsa-native

hanno-becker · 2026-02-05T14:08:12Z

This commit ensures that all non-static, non-assembly symbols declared by mldsa-native are explicitly marked as internal or external via the MLD_CONFIG_INTERNAL_API_QUALIFIER / MLD_CONFIG_EXTERNAL_API_QUALIFIER configuration options.

In particular, when mldsa-native is being built in a monobuild and MLD_CONFIG_INTERNAL_API_QUALIFIER set to static, only the FIPS204 API should be of external linkage.
If mldsa-native is being built in a monobuild, directly included into another compilation unit, and both MLD_CONFIG_INTERNAL_API_QUALIFIER and MLD_CONFIG_EXTERNAL_API_QUALIFIER set to static, no non-assembly symbols should be generated.

Part of Ensure that all non-static symbols are guarded by MLD_CONFIG_{INTERNAL/EXTERNAL}_API_QUALIFIER #936

oqs-bot · 2026-02-06T06:33:41Z

CBMC Results (ML-DSA-44)

Full Results (174 proofs)

Proof	Status	Current	Previous	Change
`TOTAL`	✅	2047s	2091s	-2.1%
`mld_attempt_signature_generation`	✅	264s	220s	+20%
`polyvecl_pointwise_acc_montgomery_c`	✅	222s	205s	+8%
`sign_verify_internal`	✅	184s	259s	-29%
`poly_pointwise_montgomery_c`	✅	146s	131s	+11%
`rej_uniform_native`	✅	130s	128s	+2%
`mld_ct_memcmp`	✅	85s	80s	+6%
`mld_ntt_layer`	✅	63s	43s	+47%
`mld_invntt_layer`	✅	50s	122s	-59%
`keccak_squeezeblocks_x4`	✅	40s	46s	-13%
`sign_signature_internal`	✅	38s	43s	-12%
`polyvec_matrix_expand`	✅	27s	29s	-7%
`poly_uniform_eta_4x`	✅	21s	17s	+24%
`fqmul`	✅	20s	20s	+0%
`rej_uniform`	✅	20s	23s	-13%
`poly_chknorm_c`	✅	19s	18s	+6%
`rej_uniform_c`	✅	19s	20s	-5%
`poly_uniform_4x`	✅	15s	14s	+7%
`polymat_permute_bitrev_to_custom`	✅	15s	15s	+0%
`keccakf1600x4_permute_native`	✅	14s	12s	+17%
`mld_compute_t0_t1_tr_from_sk_components`	✅	14s	15s	-7%
`polyt0_unpack`	✅	14s	16s	-12%
`mld_ntt_butterfly_block`	✅	13s	11s	+18%
`polyeta_unpack`	✅	13s	14s	-7%
`polyz_unpack_c`	✅	12s	12s	+0%
`keccak_absorb_once_x4`	✅	10s	12s	-17%
`mld_polyvecl_permute_bitrev_to_custom_native`	✅	10s	9s	+11%
`polyveck_add`	✅	10s	7s	+43%
`keccakf1600_permute`	✅	9s	8s	+12%
`poly_invntt_tomont_c`	✅	9s	5s	+80%
`keccakf1600_permute_native`	✅	8s	11s	-27%
`polyvec_matrix_expand_serial`	✅	8s	7s	+14%
`sign_keypair`	✅	8s	2s	+300%
`sign_pk_from_sk`	✅	8s	8s	+0%
`sign_signature_extmu`	✅	8s	3s	+167%
`polyeta_pack`	✅	7s	4s	+75%
`polyveck_decompose`	✅	7s	5s	+40%
`keccak_absorb`	✅	6s	6s	+0%
`mld_compute_pack_z`	✅	6s	8s	-25%
`mld_prepare_domain_separation_prefix`	✅	6s	4s	+50%
`poly_use_hint_native`	✅	6s	3s	+100%
`polyvec_matrix_pointwise_montgomery`	✅	6s	9s	-33%
`polyveck_caddq`	✅	6s	5s	+20%
`polyveck_ntt`	✅	6s	4s	+50%
`polyveck_pointwise_poly_montgomery`	✅	6s	5s	+20%
`polyveck_shiftl`	✅	6s	6s	+0%
`polyvecl_chknorm`	✅	6s	7s	-14%
`rej_eta_native`	✅	6s	6s	+0%
`sign`	✅	6s	5s	+20%
`fqscale`	✅	5s	4s	+25%
`mld_check_pct`	✅	5s	11s	-55%
`mld_ct_cmask_neg_i32`	✅	5s	2s	+150%
`mld_h`	✅	5s	4s	+25%
`mld_sample_s1_s2`	✅	5s	5s	+0%
`poly_add`	✅	5s	3s	+67%
`poly_challenge`	✅	5s	4s	+25%
`poly_chknorm`	✅	5s	2s	+150%
`poly_invntt_tomont_native`	✅	5s	3s	+67%
`poly_uniform`	✅	5s	2s	+150%
`poly_uniform_gamma1`	✅	5s	5s	+0%
`poly_uniform_gamma1_4x`	✅	5s	3s	+67%
`polyveck_chknorm`	✅	5s	3s	+67%
`polyveck_power2round`	✅	5s	4s	+25%
`polyveck_reduce`	✅	5s	6s	-17%
`rej_eta_c`	✅	5s	5s	+0%
`shake256`	✅	5s	3s	+67%
`shake256_init`	✅	5s	2s	+150%
`shake256x4_squeezeblocks`	✅	5s	3s	+67%
`sign_verify`	✅	5s	3s	+67%
`sign_verify_extmu`	✅	5s	4s	+25%
`unpack_hints`	✅	5s	8s	-38%
`caddq`	✅	4s	3s	+33%
`mld_ct_cmask_nonzero_u32`	✅	4s	2s	+100%
`mld_ct_get_optblocker_u32`	✅	4s	2s	+100%
`pack_sig_c_h`	✅	4s	3s	+33%
`pack_sig_z`	✅	4s	6s	-33%
`poly_caddq`	✅	4s	3s	+33%
`poly_chknorm_native`	✅	4s	2s	+100%
`poly_decompose_c`	✅	4s	4s	+0%
`poly_decompose_native`	✅	4s	3s	+33%
`poly_ntt_c`	✅	4s	3s	+33%
`poly_pointwise_montgomery`	✅	4s	4s	+0%
`poly_shiftl`	✅	4s	5s	-20%
`poly_uniform_eta`	✅	4s	6s	-33%
`poly_use_hint_c`	✅	4s	5s	-20%
`polyt0_pack`	✅	4s	2s	+100%
`polyveck_invntt_tomont`	✅	4s	4s	+0%
`polyveck_make_hint`	✅	4s	4s	+0%
`polyveck_pack_t0`	✅	4s	3s	+33%
`polyveck_sub`	✅	4s	6s	-33%
`polyveck_unpack_eta`	✅	4s	3s	+33%
`polyveck_use_hint`	✅	4s	6s	-33%
`polyvecl_ntt`	✅	4s	4s	+0%
`polyvecl_uniform_gamma1`	✅	4s	3s	+33%
`polyvecl_unpack_z`	✅	4s	2s	+100%
`polyw1_pack`	✅	4s	2s	+100%
`power2round`	✅	4s	3s	+33%
`shake128_finalize`	✅	4s	3s	+33%
`sign_keypair_internal`	✅	4s	5s	-20%
`sign_signature_pre_hash_shake256`	✅	4s	3s	+33%
`unpack_sk`	✅	4s	7s	-43%
`use_hint`	✅	4s	3s	+33%
`decompose`	✅	3s	4s	-25%
`keccak_finalize`	✅	3s	3s	+0%
`keccak_squeeze`	✅	3s	2s	+50%
`keccakf1600x4_extract_bytes`	✅	3s	3s	+0%
`make_hint`	✅	3s	3s	+0%
`mld_ct_abs_i32`	✅	3s	2s	+50%
`mld_ct_cmask_nonzero_u8`	✅	3s	3s	+0%
`mld_ct_sel_int32`	✅	3s	5s	-40%
`mld_keccakf1600_extract_bytes`	✅	3s	3s	+0%
`mld_sample_s1_s2_serial`	✅	3s	6s	-50%
`mld_value_barrier_u8`	✅	3s	4s	-25%
`montgomery_reduce`	✅	3s	2s	+50%
`ntt_native_x86_64`	✅	3s	3s	+0%
`pack_pk`	✅	3s	4s	-25%
`pack_sk`	✅	3s	2s	+50%
`poly_caddq_c`	✅	3s	4s	-25%
`poly_invntt_tomont`	✅	3s	2s	+50%
`poly_make_hint`	✅	3s	4s	-25%
`poly_ntt_native`	✅	3s	2s	+50%
`poly_power2round`	✅	3s	3s	+0%
`polyt1_unpack`	✅	3s	2s	+50%
`polyveck_pack_eta`	✅	3s	3s	+0%
`polyveck_pack_w1`	✅	3s	3s	+0%
`polyveck_unpack_t0`	✅	3s	3s	+0%
`polyvecl_permute_bitrev_to_custom`	✅	3s	3s	+0%
`polyvecl_pointwise_acc_montgomery`	✅	3s	4s	-25%
`polyvecl_uniform_gamma1_serial`	✅	3s	2s	+50%
`polyz_pack`	✅	3s	2s	+50%
`reduce32`	✅	3s	2s	+50%
`rej_eta`	✅	3s	2s	+50%
`shake128_release`	✅	3s	2s	+50%
`shake128_squeeze`	✅	3s	4s	-25%
`shake128x4_squeezeblocks`	✅	3s	2s	+50%
`shake256_absorb`	✅	3s	3s	+0%
`shake256_release`	✅	3s	3s	+0%
`shake256_squeeze`	✅	3s	2s	+50%
`sign_open`	✅	3s	3s	+0%
`sign_signature`	✅	3s	6s	-50%
`sign_signature_pre_hash_internal`	✅	3s	3s	+0%
`sign_verify_pre_hash_shake256`	✅	3s	7s	-57%
`unpack_pk`	✅	3s	2s	+50%
`keccak_init`	✅	2s	3s	-33%
`keccakf1600_extract_bytes (big endian)`	✅	2s	4s	-50%
`keccakf1600_xor_bytes`	✅	2s	3s	-33%
`keccakf1600x4_xor_bytes`	✅	2s	2s	+0%
`mld_ct_get_optblocker_u8`	✅	2s	3s	-33%
`mld_value_barrier_i64`	✅	2s	2s	+0%
`mld_value_barrier_u32`	✅	2s	3s	-33%
`poly_caddq_native`	✅	2s	2s	+0%
`poly_caddq_native_aarch64`	✅	2s	4s	-50%
`poly_decompose`	✅	2s	3s	-33%
`poly_ntt`	✅	2s	3s	-33%
`poly_pointwise_montgomery_native`	✅	2s	4s	-50%
`poly_sub`	✅	2s	3s	-33%
`poly_use_hint`	✅	2s	3s	-33%
`polyt1_pack`	✅	2s	4s	-50%
`polyvecl_pack_eta`	✅	2s	4s	-50%
`polyvecl_pointwise_acc_montgomery_native`	✅	2s	6s	-67%
`polyvecl_unpack_eta`	✅	2s	3s	-33%
`polyz_unpack`	✅	2s	2s	+0%
`polyz_unpack_native`	✅	2s	4s	-50%
`shake128_absorb`	✅	2s	4s	-50%
`shake256_finalize`	✅	2s	3s	-33%
`shake256x4_absorb_once`	✅	2s	3s	-33%
`sign_verify_pre_hash_internal`	✅	2s	4s	-50%
`sys_check_capability`	✅	2s	3s	-33%
`unpack_sig`	✅	2s	4s	-50%
`keccakf1600_xor_bytes (big endian)`	✅	1s	1s	+0%
`keccakf1600x4_permute`	✅	1s	2s	-50%
`mld_ct_get_optblocker_i64`	✅	1s	2s	-50%
`poly_reduce`	✅	1s	2s	-50%
`shake128_init`	✅	1s	2s	-50%
`shake128x4_absorb_once`	✅	1s	4s	-75%

oqs-bot · 2026-02-06T06:33:54Z

CBMC Results (ML-DSA-87)

⚠️ Attention Required

Proof	Status	Current	Previous	Change
`mld_invntt_layer`	⚠️	116s	71s	+63%
`poly_invntt_tomont_c`	⚠️	48s	8s	+500%

Full Results (174 proofs)

Proof	Status	Current	Previous	Change
`TOTAL`	✅	2443s	2294s	+6.5%
`sign_verify_internal`	✅	300s	215s	+40%
`mld_attempt_signature_generation`	✅	221s	241s	-8%
`polyvecl_pointwise_acc_montgomery_c`	✅	173s	177s	-2%
`poly_pointwise_montgomery_c`	✅	134s	143s	-6%
`polyvec_matrix_expand`	✅	132s	134s	-1%
`rej_uniform_native`	✅	127s	131s	-3%
`mld_invntt_layer`	⚠️	116s	71s	+63%
`polyvec_matrix_expand_serial`	✅	102s	107s	-5%
`mld_ct_memcmp`	✅	80s	77s	+4%
`mld_ntt_layer`	✅	72s	51s	+41%
`poly_invntt_tomont_c`	⚠️	48s	8s	+500%
`sign_signature_internal`	✅	45s	39s	+15%
`keccak_squeezeblocks_x4`	✅	41s	45s	-9%
`mld_compute_t0_t1_tr_from_sk_components`	✅	25s	25s	+0%
`polymat_permute_bitrev_to_custom`	✅	25s	26s	-4%
`rej_uniform`	✅	20s	20s	+0%
`poly_chknorm_c`	✅	19s	17s	+12%
`fqmul`	✅	18s	21s	-14%
`rej_uniform_c`	✅	17s	17s	+0%
`poly_uniform_4x`	✅	15s	15s	+0%
`polyt0_unpack`	✅	15s	14s	+7%
`polyvec_matrix_pointwise_montgomery`	✅	15s	14s	+7%
`polyveck_add`	✅	15s	14s	+7%
`polyveck_power2round`	✅	15s	14s	+7%
`poly_uniform_eta_4x`	✅	14s	18s	-22%
`polyeta_unpack`	✅	14s	15s	-7%
`keccakf1600x4_permute_native`	✅	12s	13s	-8%
`keccak_absorb_once_x4`	✅	11s	12s	-8%
`keccakf1600_permute`	✅	11s	10s	+10%
`keccakf1600_permute_native`	✅	11s	9s	+22%
`mld_ntt_butterfly_block`	✅	11s	11s	+0%
`polyveck_invntt_tomont`	✅	11s	7s	+57%
`polyveck_reduce`	✅	11s	8s	+38%
`polyvecl_ntt`	✅	11s	8s	+38%
`mld_check_pct`	✅	10s	9s	+11%
`sign_pk_from_sk`	✅	10s	9s	+11%
`polyveck_caddq`	✅	9s	9s	+0%
`mld_polyvecl_permute_bitrev_to_custom_native`	✅	8s	10s	-20%
`mld_sample_s1_s2_serial`	✅	8s	7s	+14%
`poly_decompose_c`	✅	8s	7s	+14%
`polyveck_ntt`	✅	8s	7s	+14%
`polyz_unpack_c`	✅	8s	5s	+60%
`sign`	✅	8s	9s	-11%
`sign_signature_pre_hash_shake256`	✅	8s	4s	+100%
`mld_compute_pack_z`	✅	7s	7s	+0%
`polyveck_chknorm`	✅	7s	7s	+0%
`polyveck_pointwise_poly_montgomery`	✅	7s	8s	-12%
`polyveck_use_hint`	✅	7s	6s	+17%
`unpack_sk`	✅	7s	4s	+75%
`poly_uniform_eta`	✅	6s	6s	+0%
`polyveck_decompose`	✅	6s	9s	-33%
`polyveck_shiftl`	✅	6s	6s	+0%
`polyveck_sub`	✅	6s	9s	-33%
`polyveck_unpack_t0`	✅	6s	6s	+0%
`keccak_absorb`	✅	5s	6s	-17%
`mld_sample_s1_s2`	✅	5s	8s	-38%
`pack_pk`	✅	5s	2s	+150%
`poly_invntt_tomont_native`	✅	5s	5s	+0%
`poly_pointwise_montgomery`	✅	5s	2s	+150%
`poly_pointwise_montgomery_native`	✅	5s	1s	+400%
`poly_reduce`	✅	5s	4s	+25%
`poly_use_hint`	✅	5s	3s	+67%
`polyeta_pack`	✅	5s	2s	+150%
`polyt1_pack`	✅	5s	3s	+67%
`polyveck_make_hint`	✅	5s	5s	+0%
`polyveck_pack_t0`	✅	5s	3s	+67%
`polyveck_unpack_eta`	✅	5s	4s	+25%
`polyvecl_chknorm`	✅	5s	6s	-17%
`polyvecl_uniform_gamma1_serial`	✅	5s	5s	+0%
`rej_eta_c`	✅	5s	5s	+0%
`rej_eta_native`	✅	5s	3s	+67%
`sign_keypair_internal`	✅	5s	4s	+25%
`sign_verify`	✅	5s	5s	+0%
`sign_verify_pre_hash_internal`	✅	5s	4s	+25%
`unpack_hints`	✅	5s	5s	+0%
`unpack_pk`	✅	5s	5s	+0%
`unpack_sig`	✅	5s	2s	+150%
`decompose`	✅	4s	2s	+100%
`fqscale`	✅	4s	3s	+33%
`keccak_squeeze`	✅	4s	5s	-20%
`keccakf1600x4_extract_bytes`	✅	4s	2s	+100%
`make_hint`	✅	4s	3s	+33%
`mld_value_barrier_i64`	✅	4s	3s	+33%
`montgomery_reduce`	✅	4s	3s	+33%
`poly_add`	✅	4s	6s	-33%
`poly_chknorm`	✅	4s	5s	-20%
`poly_invntt_tomont`	✅	4s	5s	-20%
`poly_make_hint`	✅	4s	2s	+100%
`poly_sub`	✅	4s	2s	+100%
`poly_uniform_gamma1_4x`	✅	4s	6s	-33%
`polyt0_pack`	✅	4s	4s	+0%
`polyveck_pack_w1`	✅	4s	4s	+0%
`polyvecl_permute_bitrev_to_custom`	✅	4s	4s	+0%
`polyvecl_pointwise_acc_montgomery_native`	✅	4s	7s	-43%
`polyvecl_unpack_eta`	✅	4s	4s	+0%
`polyvecl_unpack_z`	✅	4s	5s	-20%
`rej_eta`	✅	4s	2s	+100%
`shake128_absorb`	✅	4s	1s	+300%
`sign_signature`	✅	4s	2s	+100%
`sign_verify_pre_hash_shake256`	✅	4s	4s	+0%
`sys_check_capability`	✅	4s	2s	+100%
`keccakf1600_xor_bytes (big endian)`	✅	3s	4s	-25%
`keccakf1600x4_permute`	✅	3s	2s	+50%
`mld_ct_get_optblocker_i64`	✅	3s	4s	-25%
`mld_ct_sel_int32`	✅	3s	1s	+200%
`mld_prepare_domain_separation_prefix`	✅	3s	3s	+0%
`pack_sk`	✅	3s	2s	+50%
`poly_challenge`	✅	3s	5s	-40%
`poly_chknorm_native`	✅	3s	3s	+0%
`poly_decompose`	✅	3s	2s	+50%
`poly_ntt`	✅	3s	3s	+0%
`poly_ntt_c`	✅	3s	2s	+50%
`poly_ntt_native`	✅	3s	3s	+0%
`poly_uniform`	✅	3s	5s	-40%
`poly_uniform_gamma1`	✅	3s	5s	-40%
`poly_use_hint_c`	✅	3s	2s	+50%
`poly_use_hint_native`	✅	3s	4s	-25%
`polyt1_unpack`	✅	3s	3s	+0%
`polyveck_pack_eta`	✅	3s	2s	+50%
`polyvecl_pack_eta`	✅	3s	5s	-40%
`polyvecl_pointwise_acc_montgomery`	✅	3s	5s	-40%
`polyvecl_uniform_gamma1`	✅	3s	4s	-25%
`polyw1_pack`	✅	3s	3s	+0%
`polyz_pack`	✅	3s	3s	+0%
`polyz_unpack`	✅	3s	4s	-25%
`power2round`	✅	3s	3s	+0%
`shake128_release`	✅	3s	4s	-25%
`shake128x4_absorb_once`	✅	3s	2s	+50%
`shake128x4_squeezeblocks`	✅	3s	4s	-25%
`shake256_absorb`	✅	3s	3s	+0%
`shake256_init`	✅	3s	1s	+200%
`sign_keypair`	✅	3s	5s	-40%
`sign_open`	✅	3s	5s	-40%
`sign_signature_extmu`	✅	3s	4s	-25%
`sign_verify_extmu`	✅	3s	3s	+0%
`caddq`	✅	2s	3s	-33%
`keccak_finalize`	✅	2s	2s	+0%
`keccak_init`	✅	2s	1s	+100%
`keccakf1600_extract_bytes (big endian)`	✅	2s	1s	+100%
`keccakf1600x4_xor_bytes`	✅	2s	2s	+0%
`mld_ct_cmask_neg_i32`	✅	2s	2s	+0%
`mld_ct_cmask_nonzero_u32`	✅	2s	4s	-50%
`mld_ct_cmask_nonzero_u8`	✅	2s	2s	+0%
`mld_ct_get_optblocker_u32`	✅	2s	3s	-33%
`mld_ct_get_optblocker_u8`	✅	2s	2s	+0%
`mld_h`	✅	2s	2s	+0%
`mld_keccakf1600_extract_bytes`	✅	2s	3s	-33%
`mld_value_barrier_u32`	✅	2s	3s	-33%
`mld_value_barrier_u8`	✅	2s	3s	-33%
`ntt_native_x86_64`	✅	2s	5s	-60%
`pack_sig_c_h`	✅	2s	4s	-50%
`pack_sig_z`	✅	2s	3s	-33%
`poly_caddq_c`	✅	2s	5s	-60%
`poly_caddq_native`	✅	2s	5s	-60%
`poly_caddq_native_aarch64`	✅	2s	5s	-60%
`poly_decompose_native`	✅	2s	2s	+0%
`poly_power2round`	✅	2s	5s	-60%
`poly_shiftl`	✅	2s	3s	-33%
`polyz_unpack_native`	✅	2s	2s	+0%
`reduce32`	✅	2s	2s	+0%
`shake128_finalize`	✅	2s	2s	+0%
`shake128_init`	✅	2s	2s	+0%
`shake128_squeeze`	✅	2s	2s	+0%
`shake256`	✅	2s	4s	-50%
`shake256_release`	✅	2s	2s	+0%
`shake256_squeeze`	✅	2s	2s	+0%
`shake256x4_squeezeblocks`	✅	2s	4s	-50%
`sign_signature_pre_hash_internal`	✅	2s	4s	-50%
`use_hint`	✅	2s	4s	-50%
`keccakf1600_xor_bytes`	✅	1s	2s	-50%
`mld_ct_abs_i32`	✅	1s	2s	-50%
`poly_caddq`	✅	1s	4s	-75%
`shake256_finalize`	✅	1s	2s	-50%
`shake256x4_absorb_once`	✅	1s	2s	-50%

oqs-bot · 2026-02-06T06:35:26Z

CBMC Results (ML-DSA-65)

⚠️ Attention Required

Proof	Status	Current	Previous	Change
`mld_invntt_layer`	⚠️	118s	69s	+71%
`poly_invntt_tomont_c`	⚠️	43s	7s	+514%

Full Results (174 proofs)

Proof	Status	Current	Previous	Change
`TOTAL`	✅	2265s	2280s	-0.7%
`polyvecl_pointwise_acc_montgomery_c`	✅	228s	219s	+4%
`sign_verify_internal`	✅	204s	341s	-40%
`mld_attempt_signature_generation`	✅	193s	202s	-4%
`poly_pointwise_montgomery_c`	✅	132s	133s	-1%
`rej_uniform_native`	✅	127s	127s	+0%
`mld_invntt_layer`	⚠️	118s	69s	+71%
`polyvec_matrix_expand`	✅	94s	94s	+0%
`mld_ct_memcmp`	✅	81s	77s	+5%
`mld_ntt_layer`	✅	71s	50s	+42%
`polyvec_matrix_expand_serial`	✅	65s	63s	+3%
`sign_signature_internal`	✅	45s	43s	+5%
`poly_invntt_tomont_c`	⚠️	43s	7s	+514%
`keccak_squeezeblocks_x4`	✅	40s	43s	-7%
`mld_compute_t0_t1_tr_from_sk_components`	✅	26s	27s	-4%
`rej_uniform`	✅	22s	22s	+0%
`poly_chknorm_c`	✅	18s	16s	+12%
`polymat_permute_bitrev_to_custom`	✅	18s	19s	-5%
`fqmul`	✅	17s	19s	-11%
`polyveck_decompose`	✅	17s	16s	+6%
`rej_uniform_c`	✅	17s	16s	+6%
`poly_uniform_eta_4x`	✅	16s	16s	+0%
`polyt0_unpack`	✅	15s	15s	+0%
`poly_uniform_4x`	✅	14s	15s	-7%
`polyvec_matrix_pointwise_montgomery`	✅	14s	14s	+0%
`keccak_absorb_once_x4`	✅	13s	11s	+18%
`keccakf1600x4_permute_native`	✅	13s	12s	+8%
`mld_ntt_butterfly_block`	✅	12s	10s	+20%
`polyveck_add`	✅	10s	7s	+43%
`sign`	✅	10s	9s	+11%
`polyveck_use_hint`	✅	9s	6s	+50%
`keccakf1600_permute`	✅	8s	9s	-11%
`keccakf1600_permute_native`	✅	8s	9s	-11%
`mld_check_pct`	✅	8s	7s	+14%
`polyveck_caddq`	✅	8s	6s	+33%
`mld_polyvecl_permute_bitrev_to_custom_native`	✅	7s	7s	+0%
`poly_decompose_c`	✅	7s	9s	-22%
`polyveck_invntt_tomont`	✅	7s	7s	+0%
`polyveck_power2round`	✅	7s	9s	-22%
`polyveck_reduce`	✅	7s	7s	+0%
`polyvecl_ntt`	✅	7s	7s	+0%
`sign_pk_from_sk`	✅	7s	7s	+0%
`unpack_hints`	✅	7s	4s	+75%
`caddq`	✅	6s	4s	+50%
`keccakf1600x4_permute`	✅	6s	3s	+100%
`mld_sample_s1_s2`	✅	6s	4s	+50%
`pack_sig_z`	✅	6s	6s	+0%
`poly_make_hint`	✅	6s	5s	+20%
`poly_ntt_native`	✅	6s	2s	+200%
`poly_use_hint_c`	✅	6s	7s	-14%
`polyeta_unpack`	✅	6s	5s	+20%
`polyveck_ntt`	✅	6s	9s	-33%
`polyveck_pointwise_poly_montgomery`	✅	6s	5s	+20%
`polyveck_shiftl`	✅	6s	6s	+0%
`polyveck_sub`	✅	6s	6s	+0%
`sign_open`	✅	6s	3s	+100%
`keccak_absorb`	✅	5s	8s	-38%
`mld_compute_pack_z`	✅	5s	4s	+25%
`mld_ct_cmask_nonzero_u32`	✅	5s	2s	+150%
`mld_h`	✅	5s	4s	+25%
`poly_ntt`	✅	5s	5s	+0%
`poly_uniform_gamma1`	✅	5s	4s	+25%
`polyt1_pack`	✅	5s	4s	+25%
`polyveck_make_hint`	✅	5s	5s	+0%
`polyveck_pack_eta`	✅	5s	6s	-17%
`polyveck_unpack_t0`	✅	5s	3s	+67%
`polyvecl_chknorm`	✅	5s	4s	+25%
`polyvecl_pointwise_acc_montgomery_native`	✅	5s	3s	+67%
`polyvecl_uniform_gamma1_serial`	✅	5s	4s	+25%
`rej_eta_c`	✅	5s	4s	+25%
`rej_eta_native`	✅	5s	9s	-44%
`sign_keypair`	✅	5s	3s	+67%
`sign_signature_pre_hash_internal`	✅	5s	2s	+150%
`sign_signature_pre_hash_shake256`	✅	5s	6s	-17%
`sign_verify_pre_hash_shake256`	✅	5s	6s	-17%
`unpack_sk`	✅	5s	4s	+25%
`keccakf1600_extract_bytes (big endian)`	✅	4s	3s	+33%
`keccakf1600_xor_bytes`	✅	4s	4s	+0%
`make_hint`	✅	4s	2s	+100%
`mld_prepare_domain_separation_prefix`	✅	4s	6s	-33%
`ntt_native_x86_64`	✅	4s	2s	+100%
`poly_challenge`	✅	4s	4s	+0%
`poly_chknorm`	✅	4s	2s	+100%
`poly_decompose_native`	✅	4s	2s	+100%
`poly_ntt_c`	✅	4s	4s	+0%
`poly_power2round`	✅	4s	6s	-33%
`poly_reduce`	✅	4s	2s	+100%
`poly_uniform_eta`	✅	4s	4s	+0%
`poly_uniform_gamma1_4x`	✅	4s	4s	+0%
`poly_use_hint`	✅	4s	4s	+0%
`poly_use_hint_native`	✅	4s	3s	+33%
`polyeta_pack`	✅	4s	3s	+33%
`polyt1_unpack`	✅	4s	3s	+33%
`polyveck_chknorm`	✅	4s	6s	-33%
`polyveck_pack_w1`	✅	4s	5s	-20%
`polyveck_unpack_eta`	✅	4s	4s	+0%
`polyvecl_pointwise_acc_montgomery`	✅	4s	6s	-33%
`polyvecl_uniform_gamma1`	✅	4s	2s	+100%
`polyvecl_unpack_z`	✅	4s	3s	+33%
`polyw1_pack`	✅	4s	3s	+33%
`polyz_unpack_c`	✅	4s	5s	-20%
`power2round`	✅	4s	3s	+33%
`shake128_finalize`	✅	4s	2s	+100%
`shake128_init`	✅	4s	3s	+33%
`shake256_init`	✅	4s	3s	+33%
`shake256_release`	✅	4s	3s	+33%
`sign_keypair_internal`	✅	4s	5s	-20%
`sign_signature_extmu`	✅	4s	4s	+0%
`use_hint`	✅	4s	3s	+33%
`decompose`	✅	3s	4s	-25%
`keccak_init`	✅	3s	2s	+50%
`keccak_squeeze`	✅	3s	3s	+0%
`keccakf1600x4_extract_bytes`	✅	3s	3s	+0%
`keccakf1600x4_xor_bytes`	✅	3s	3s	+0%
`mld_ct_abs_i32`	✅	3s	5s	-40%
`mld_ct_cmask_neg_i32`	✅	3s	3s	+0%
`mld_ct_get_optblocker_i64`	✅	3s	4s	-25%
`mld_keccakf1600_extract_bytes`	✅	3s	4s	-25%
`mld_sample_s1_s2_serial`	✅	3s	6s	-50%
`mld_value_barrier_i64`	✅	3s	1s	+200%
`mld_value_barrier_u8`	✅	3s	4s	-25%
`montgomery_reduce`	✅	3s	1s	+200%
`pack_sk`	✅	3s	3s	+0%
`poly_add`	✅	3s	3s	+0%
`poly_caddq_c`	✅	3s	3s	+0%
`poly_chknorm_native`	✅	3s	4s	-25%
`poly_invntt_tomont`	✅	3s	4s	-25%
`poly_pointwise_montgomery_native`	✅	3s	5s	-40%
`poly_shiftl`	✅	3s	2s	+50%
`poly_sub`	✅	3s	2s	+50%
`poly_uniform`	✅	3s	3s	+0%
`polyt0_pack`	✅	3s	5s	-40%
`polyveck_pack_t0`	✅	3s	2s	+50%
`polyvecl_pack_eta`	✅	3s	2s	+50%
`polyvecl_permute_bitrev_to_custom`	✅	3s	3s	+0%
`polyvecl_unpack_eta`	✅	3s	2s	+50%
`polyz_pack`	✅	3s	4s	-25%
`polyz_unpack_native`	✅	3s	4s	-25%
`shake128_release`	✅	3s	1s	+200%
`shake128_squeeze`	✅	3s	2s	+50%
`shake128x4_absorb_once`	✅	3s	3s	+0%
`shake256`	✅	3s	3s	+0%
`shake256_finalize`	✅	3s	1s	+200%
`sign_signature`	✅	3s	3s	+0%
`sign_verify`	✅	3s	4s	-25%
`sign_verify_pre_hash_internal`	✅	3s	4s	-25%
`fqscale`	✅	2s	2s	+0%
`keccak_finalize`	✅	2s	4s	-50%
`keccakf1600_xor_bytes (big endian)`	✅	2s	2s	+0%
`mld_ct_get_optblocker_u32`	✅	2s	5s	-60%
`mld_ct_get_optblocker_u8`	✅	2s	3s	-33%
`pack_pk`	✅	2s	2s	+0%
`pack_sig_c_h`	✅	2s	3s	-33%
`poly_caddq`	✅	2s	4s	-50%
`poly_caddq_native`	✅	2s	4s	-50%
`poly_caddq_native_aarch64`	✅	2s	3s	-33%
`poly_decompose`	✅	2s	2s	+0%
`poly_invntt_tomont_native`	✅	2s	2s	+0%
`poly_pointwise_montgomery`	✅	2s	3s	-33%
`polyz_unpack`	✅	2s	3s	-33%
`reduce32`	✅	2s	2s	+0%
`rej_eta`	✅	2s	3s	-33%
`shake128_absorb`	✅	2s	3s	-33%
`shake128x4_squeezeblocks`	✅	2s	2s	+0%
`shake256_absorb`	✅	2s	3s	-33%
`shake256_squeeze`	✅	2s	2s	+0%
`shake256x4_absorb_once`	✅	2s	2s	+0%
`shake256x4_squeezeblocks`	✅	2s	3s	-33%
`sign_verify_extmu`	✅	2s	4s	-50%
`unpack_pk`	✅	2s	3s	-33%
`unpack_sig`	✅	2s	4s	-50%
`mld_ct_cmask_nonzero_u8`	✅	1s	3s	-67%
`mld_ct_sel_int32`	✅	1s	2s	-50%
`mld_value_barrier_u32`	✅	1s	5s	-80%
`sys_check_capability`	✅	1s	3s	-67%

mkannwischer

Thanks @hanno-becker. The changes look good to me.
Strictly speaking you are not resolving #936 though.

This commit ensures that all non-static, non-assembly symbols declared by mldsa-native are explicitly marked as internal or external via the MLD_CONFIG_INTERNAL_API_QUALIFIER / MLD_CONFIG_EXTERNAL_API_QUALIFIER configuration options. In particular, when mldsa-native is being built in a monobuild and MLD_CONFIG_INTERNAL_API_QUALIFIER set to `static`, only the FIPS204 API should be of external linkage. If mldsa-native is being built in a monobuild, directly included into another compilation unit, and both MLD_CONFIG_INTERNAL_API_QUALIFIER and MLD_CONFIG_EXTERNAL_API_QUALIFIER set to `static`, no non-assembly symbols should be generated. Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>

mkannwischer added the needs-mlkem-native-port label Feb 5, 2026

hanno-becker force-pushed the fix-api-qualifiers-936 branch from ea4a609 to 9470dbe Compare February 6, 2026 06:16

hanno-becker force-pushed the fix-api-qualifiers-936 branch 2 times, most recently from 5302946 to cd7a440 Compare February 6, 2026 08:58

hanno-becker marked this pull request as ready for review February 6, 2026 08:58

hanno-becker requested a review from a team as a code owner February 6, 2026 08:58

hanno-becker requested a review from mkannwischer February 6, 2026 09:30

mkannwischer approved these changes Feb 6, 2026

View reviewed changes

flynd mentioned this pull request Feb 6, 2026

Ensure that all non-static symbols are guarded by MLD_CONFIG_{INTERNAL/EXTERNAL}_API_QUALIFIER #936

Open

1 task

hanno-becker force-pushed the fix-api-qualifiers-936 branch from cd7a440 to 009f8a2 Compare February 6, 2026 20:28

hanno-becker marked this pull request as draft February 6, 2026 20:30

hanno-becker force-pushed the fix-api-qualifiers-936 branch 2 times, most recently from 038f696 to e45d93a Compare February 6, 2026 20:33

hanno-becker marked this pull request as ready for review February 6, 2026 20:33

hanno-becker force-pushed the fix-api-qualifiers-936 branch from e45d93a to 04e3029 Compare February 7, 2026 04:03

mkannwischer merged commit 2fde6ae into main Feb 7, 2026
371 checks passed

mkannwischer deleted the fix-api-qualifiers-936 branch February 7, 2026 05:01

mkannwischer mentioned this pull request Feb 7, 2026

Port: Mark all non-static declarations as internal or external pq-code-package/mlkem-native#1553

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mark all non-static declarations as internal or external#951

Mark all non-static declarations as internal or external#951
mkannwischer merged 1 commit intomainfrom
fix-api-qualifiers-936

hanno-becker commented Feb 5, 2026 •

edited

Loading

Uh oh!

oqs-bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

oqs-bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

oqs-bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

mkannwischer left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

hanno-becker commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oqs-bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CBMC Results (ML-DSA-44)

Uh oh!

oqs-bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CBMC Results (ML-DSA-87)

Uh oh!

oqs-bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CBMC Results (ML-DSA-65)

Uh oh!

mkannwischer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hanno-becker commented Feb 5, 2026 •

edited

Loading

oqs-bot commented Feb 6, 2026 •

edited

Loading

oqs-bot commented Feb 6, 2026 •

edited

Loading

oqs-bot commented Feb 6, 2026 •

edited

Loading