Skip to content

Use MLD_MUST_CHECK_RETURN_VALUE for all functions with return values#931

Merged
mkannwischer merged 1 commit intomainfrom
can_fail_must_check_port
Feb 8, 2026
Merged

Use MLD_MUST_CHECK_RETURN_VALUE for all functions with return values#931
mkannwischer merged 1 commit intomainfrom
can_fail_must_check_port

Conversation

@f15hr
Copy link
Contributor

@f15hr f15hr commented Feb 1, 2026

Resolves #856

"Enforcing internal error checking discipline. In particular, this applies to the backend APIs that can now signal fallback -- this must always be checked."

@oqs-bot
Copy link
Contributor

oqs-bot commented Feb 1, 2026

CBMC Results (ML-DSA-44)

Full Results (174 proofs)
Proof Status Current Previous Change
**TOTAL** 1987s 1991s -0.2%
mld_attempt_signature_generation 240s 260s -8%
polyvecl_pointwise_acc_montgomery_c 213s 214s -0%
sign_verify_internal 175s 178s -2%
poly_pointwise_montgomery_c 135s 133s +2%
rej_uniform_native 130s 131s -1%
mld_ct_memcmp 83s 81s +2%
mld_invntt_layer 72s 49s +47%
mld_ntt_layer 54s 60s -10%
keccak_squeezeblocks_x4 44s 42s +5%
sign_signature_internal 41s 36s +14%
rej_uniform_c 21s 17s +24%
fqmul 20s 19s +5%
rej_uniform 20s 22s -9%
polyvec_matrix_expand 18s 28s -36%
poly_chknorm_c 17s 17s +0%
polymat_permute_bitrev_to_custom 17s 15s +13%
poly_uniform_eta_4x 16s 16s +0%
polyt0_unpack 16s 14s +14%
mld_compute_t0_t1_tr_from_sk_components 15s 17s -12%
keccakf1600x4_permute_native 14s 15s -7%
poly_uniform_4x 14s 15s -7%
mld_ntt_butterfly_block 13s 13s +0%
polyeta_unpack 12s 12s +0%
polyz_unpack_c 12s 12s +0%
mld_check_pct 11s 5s +120%
keccak_absorb_once_x4 10s 12s -17%
keccakf1600_permute 10s 7s +43%
mld_polyvecl_permute_bitrev_to_custom_native 9s 8s +12%
polyveck_add 9s 12s -25%
keccakf1600_permute_native 8s 9s -11%
poly_invntt_tomont_c 8s 7s +14%
polyveck_decompose 8s 7s +14%
polyvec_matrix_pointwise_montgomery 7s 8s -12%
polyveck_caddq 7s 5s +40%
polyveck_reduce 7s 7s +0%
polyveck_sub 7s 6s +17%
sign_verify_pre_hash_internal 7s 3s +133%
mld_compute_pack_z 6s 8s -25%
poly_caddq 6s 3s +100%
poly_challenge 6s 3s +100%
poly_ntt_c 6s 4s +50%
polyvec_matrix_expand_serial 6s 5s +20%
polyveck_power2round 6s 3s +100%
polyvecl_unpack_eta 6s 3s +100%
sign_signature 6s 4s +50%
sign_signature_extmu 6s 3s +100%
unpack_hints 6s 3s +100%
decompose 5s 3s +67%
keccak_absorb 5s 5s +0%
pack_pk 5s 4s +25%
poly_decompose 5s 2s +150%
poly_uniform_gamma1_4x 5s 6s -17%
polyveck_chknorm 5s 4s +25%
polyveck_pointwise_poly_montgomery 5s 6s -17%
polyveck_shiftl 5s 4s +25%
polyz_pack 5s 3s +67%
rej_eta_native 5s 4s +25%
shake128_init 5s 6s -17%
shake256 5s 3s +67%
sign 5s 7s -29%
sign_keypair 5s 3s +67%
sign_pk_from_sk 5s 6s -17%
sign_verify 5s 5s +0%
keccakf1600x4_extract_bytes 4s 5s -20%
mld_ct_cmask_nonzero_u32 4s 4s +0%
mld_ct_get_optblocker_i64 4s 2s +100%
mld_h 4s 3s +33%
mld_sample_s1_s2_serial 4s 6s -33%
pack_sig_c_h 4s 3s +33%
poly_decompose_c 4s 6s -33%
poly_make_hint 4s 2s +100%
poly_ntt 4s 3s +33%
poly_ntt_native 4s 3s +33%
poly_pointwise_montgomery 4s 4s +0%
poly_power2round 4s 6s -33%
poly_reduce 4s 4s +0%
poly_shiftl 4s 3s +33%
poly_uniform 4s 4s +0%
polyt0_pack 4s 3s +33%
polyveck_invntt_tomont 4s 7s -43%
polyveck_make_hint 4s 6s -33%
polyveck_ntt 4s 5s -20%
polyveck_unpack_eta 4s 3s +33%
polyvecl_chknorm 4s 4s +0%
polyvecl_ntt 4s 3s +33%
polyvecl_pack_eta 4s 4s +0%
rej_eta_c 4s 4s +0%
sign_keypair_internal 4s 5s -20%
sign_open 4s 2s +100%
sign_signature_pre_hash_internal 4s 3s +33%
sign_signature_pre_hash_shake256 4s 6s -33%
sign_verify_pre_hash_shake256 4s 5s -20%
sys_check_capability 4s 4s +0%
unpack_sk 4s 4s +0%
use_hint 4s 3s +33%
caddq 3s 3s +0%
keccak_init 3s 2s +50%
keccakf1600_xor_bytes (big endian) 3s 2s +50%
keccakf1600x4_xor_bytes 3s 2s +50%
make_hint 3s 4s -25%
mld_ct_abs_i32 3s 2s +50%
mld_ct_cmask_neg_i32 3s 1s +200%
mld_ct_get_optblocker_u32 3s 2s +50%
mld_ct_get_optblocker_u8 3s 3s +0%
mld_prepare_domain_separation_prefix 3s 4s -25%
mld_sample_s1_s2 3s 4s -25%
pack_sk 3s 4s -25%
poly_add 3s 3s +0%
poly_caddq_native_aarch64 3s 5s -40%
poly_chknorm 3s 3s +0%
poly_decompose_native 3s 3s +0%
poly_invntt_tomont 3s 5s -40%
poly_sub 3s 4s -25%
poly_uniform_eta 3s 4s -25%
poly_use_hint_c 3s 3s +0%
poly_use_hint_native 3s 4s -25%
polyt1_pack 3s 4s -25%
polyt1_unpack 3s 3s +0%
polyveck_pack_eta 3s 3s +0%
polyveck_pack_t0 3s 2s +50%
polyveck_pack_w1 3s 3s +0%
polyveck_unpack_t0 3s 4s -25%
polyveck_use_hint 3s 4s -25%
polyvecl_permute_bitrev_to_custom 3s 3s +0%
polyvecl_pointwise_acc_montgomery 3s 3s +0%
polyvecl_pointwise_acc_montgomery_native 3s 4s -25%
polyvecl_uniform_gamma1 3s 5s -40%
polyvecl_uniform_gamma1_serial 3s 4s -25%
polyw1_pack 3s 2s +50%
power2round 3s 3s +0%
reduce32 3s 3s +0%
rej_eta 3s 2s +50%
shake128_absorb 3s 2s +50%
shake128x4_absorb_once 3s 2s +50%
shake128x4_squeezeblocks 3s 3s +0%
shake256_finalize 3s 3s +0%
shake256_init 3s 2s +50%
shake256_release 3s 3s +0%
sign_verify_extmu 3s 3s +0%
unpack_pk 3s 2s +50%
unpack_sig 3s 3s +0%
fqscale 2s 3s -33%
keccak_finalize 2s 2s +0%
keccak_squeeze 2s 5s -60%
keccakf1600_extract_bytes (big endian) 2s 2s +0%
keccakf1600_xor_bytes 2s 3s -33%
mld_ct_cmask_nonzero_u8 2s 3s -33%
mld_keccakf1600_extract_bytes 2s 2s +0%
mld_value_barrier_i64 2s 2s +0%
mld_value_barrier_u32 2s 3s -33%
montgomery_reduce 2s 4s -50%
ntt_native_x86_64 2s 3s -33%
pack_sig_z 2s 4s -50%
poly_caddq_c 2s 2s +0%
poly_caddq_native 2s 2s +0%
poly_chknorm_native 2s 5s -60%
poly_invntt_tomont_native 2s 2s +0%
poly_pointwise_montgomery_native 2s 5s -60%
poly_uniform_gamma1 2s 4s -50%
poly_use_hint 2s 2s +0%
polyeta_pack 2s 2s +0%
polyvecl_unpack_z 2s 1s +100%
polyz_unpack 2s 4s -50%
shake128_release 2s 4s -50%
shake128_squeeze 2s 3s -33%
shake256_absorb 2s 3s -33%
shake256_squeeze 2s 2s +0%
shake256x4_absorb_once 2s 3s -33%
shake256x4_squeezeblocks 2s 4s -50%
keccakf1600x4_permute 1s 1s +0%
mld_ct_sel_int32 1s 3s -67%
mld_value_barrier_u8 1s 3s -67%
polyz_unpack_native 1s 4s -75%
shake128_finalize 1s 3s -67%

@oqs-bot
Copy link
Contributor

oqs-bot commented Feb 1, 2026

CBMC Results (ML-DSA-87)

Full Results (174 proofs)
Proof Status Current Previous Change
**TOTAL** 2241s 2540s -11.8%
mld_attempt_signature_generation 226s 235s -4%
polyvec_matrix_expand 173s 141s +23%
polyvecl_pointwise_acc_montgomery_c 156s 186s -16%
poly_pointwise_montgomery_c 130s 152s -14%
mld_invntt_layer 127s 121s +5%
rej_uniform_native 126s 129s -2%
sign_verify_internal 116s 319s -64%
polyvec_matrix_expand_serial 99s 109s -9%
mld_ct_memcmp 77s 88s -12%
mld_ntt_layer 76s 72s +6%
sign_signature_internal 52s 42s +24%
keccak_squeezeblocks_x4 41s 42s -2%
mld_compute_t0_t1_tr_from_sk_components 25s 26s -4%
polymat_permute_bitrev_to_custom 24s 25s -4%
fqmul 19s 19s +0%
rej_uniform 19s 20s -5%
rej_uniform_c 18s 19s -5%
poly_uniform_eta_4x 15s 14s +7%
polyveck_add 15s 14s +7%
keccakf1600x4_permute_native 14s 16s -12%
poly_chknorm_c 14s 20s -30%
poly_uniform_4x 14s 14s +0%
polyt0_unpack 14s 17s -18%
polyveck_power2round 14s 13s +8%
polyeta_unpack 13s 14s -7%
keccak_absorb_once_x4 12s 10s +20%
polyvec_matrix_pointwise_montgomery 12s 13s -8%
mld_ntt_butterfly_block 11s 13s -15%
poly_decompose_c 10s 8s +25%
polyveck_sub 10s 7s +43%
mld_polyvecl_permute_bitrev_to_custom_native 9s 10s -10%
polyveck_reduce 9s 9s +0%
polyveck_use_hint 9s 5s +80%
keccakf1600_permute 8s 7s +14%
keccakf1600_permute_native 8s 9s -11%
mld_compute_pack_z 8s 6s +33%
mld_sample_s1_s2_serial 8s 7s +14%
sign 8s 8s +0%
sign_pk_from_sk 8s 11s -27%
poly_invntt_tomont_c 7s 50s -86%
polyt0_pack 7s 3s +133%
polyveck_caddq 7s 10s -30%
polyveck_chknorm 7s 10s -30%
polyveck_make_hint 7s 4s +75%
polyveck_ntt 7s 8s -12%
polyveck_pointwise_poly_montgomery 7s 8s -12%
polyveck_shiftl 7s 6s +17%
polyvecl_ntt 7s 8s -12%
sign_keypair_internal 7s 9s -22%
sign_signature 7s 5s +40%
keccak_absorb 6s 7s -14%
mld_check_pct 6s 10s -40%
mld_sample_s1_s2 6s 6s +0%
poly_challenge 6s 5s +20%
polyveck_invntt_tomont 6s 8s -25%
polyvecl_unpack_eta 6s 4s +50%
polyz_unpack_c 6s 5s +20%
unpack_sk 6s 5s +20%
make_hint 5s 3s +67%
mld_ct_cmask_nonzero_u32 5s 2s +150%
ntt_native_x86_64 5s 3s +67%
pack_sig_c_h 5s 4s +25%
poly_shiftl 5s 1s +400%
polyveck_decompose 5s 6s -17%
polyveck_unpack_t0 5s 5s +0%
polyvecl_pointwise_acc_montgomery_native 5s 3s +67%
rej_eta_native 5s 6s -17%
shake128_squeeze 5s 4s +25%
sign_open 5s 2s +150%
sign_verify 5s 3s +67%
unpack_hints 5s 6s -17%
decompose 4s 5s -20%
keccak_finalize 4s 2s +100%
keccakf1600_xor_bytes 4s 3s +33%
mld_ct_get_optblocker_u8 4s 2s +100%
mld_ct_sel_int32 4s 3s +33%
mld_h 4s 4s +0%
mld_prepare_domain_separation_prefix 4s 3s +33%
poly_add 4s 3s +33%
poly_caddq_native_aarch64 4s 2s +100%
poly_chknorm_native 4s 2s +100%
poly_decompose 4s 4s +0%
poly_decompose_native 4s 4s +0%
poly_invntt_tomont 4s 3s +33%
poly_ntt_c 4s 5s -20%
poly_pointwise_montgomery_native 4s 4s +0%
poly_power2round 4s 3s +33%
poly_sub 4s 4s +0%
poly_uniform_eta 4s 5s -20%
poly_use_hint_native 4s 3s +33%
polyveck_unpack_eta 4s 5s -20%
polyvecl_uniform_gamma1 4s 4s +0%
power2round 4s 4s +0%
rej_eta_c 4s 5s -20%
shake256 4s 3s +33%
sign_signature_extmu 4s 3s +33%
sign_signature_pre_hash_shake256 4s 2s +100%
sign_verify_extmu 4s 4s +0%
sign_verify_pre_hash_internal 4s 6s -33%
sign_verify_pre_hash_shake256 4s 4s +0%
sys_check_capability 4s 3s +33%
unpack_pk 4s 4s +0%
caddq 3s 4s -25%
keccakf1600_extract_bytes (big endian) 3s 4s -25%
keccakf1600_xor_bytes (big endian) 3s 4s -25%
keccakf1600x4_extract_bytes 3s 3s +0%
keccakf1600x4_permute 3s 3s +0%
keccakf1600x4_xor_bytes 3s 2s +50%
mld_ct_abs_i32 3s 3s +0%
mld_ct_cmask_neg_i32 3s 2s +50%
mld_ct_cmask_nonzero_u8 3s 3s +0%
mld_ct_get_optblocker_u32 3s 3s +0%
mld_keccakf1600_extract_bytes 3s 3s +0%
mld_value_barrier_u32 3s 2s +50%
pack_pk 3s 5s -40%
pack_sig_z 3s 3s +0%
pack_sk 3s 4s -25%
poly_caddq 3s 5s -40%
poly_caddq_native 3s 2s +50%
poly_invntt_tomont_native 3s 3s +0%
poly_make_hint 3s 2s +50%
poly_uniform 3s 5s -40%
poly_uniform_gamma1 3s 4s -25%
poly_uniform_gamma1_4x 3s 4s -25%
poly_use_hint 3s 3s +0%
polyeta_pack 3s 3s +0%
polyt1_pack 3s 2s +50%
polyveck_pack_eta 3s 2s +50%
polyvecl_chknorm 3s 3s +0%
polyvecl_pack_eta 3s 3s +0%
polyvecl_uniform_gamma1_serial 3s 5s -40%
polyz_pack 3s 3s +0%
polyz_unpack 3s 3s +0%
reduce32 3s 2s +50%
shake128_absorb 3s 1s +200%
shake256_init 3s 3s +0%
shake256_release 3s 4s -25%
shake256_squeeze 3s 3s +0%
shake256x4_absorb_once 3s 3s +0%
sign_keypair 3s 4s -25%
sign_signature_pre_hash_internal 3s 2s +50%
unpack_sig 3s 4s -25%
keccak_init 2s 3s -33%
keccak_squeeze 2s 2s +0%
mld_ct_get_optblocker_i64 2s 2s +0%
mld_value_barrier_i64 2s 3s -33%
mld_value_barrier_u8 2s 2s +0%
montgomery_reduce 2s 3s -33%
poly_caddq_c 2s 5s -60%
poly_chknorm 2s 1s +100%
poly_ntt 2s 3s -33%
poly_ntt_native 2s 3s -33%
poly_pointwise_montgomery 2s 5s -60%
poly_reduce 2s 3s -33%
poly_use_hint_c 2s 3s -33%
polyt1_unpack 2s 2s +0%
polyveck_pack_t0 2s 4s -50%
polyveck_pack_w1 2s 5s -60%
polyvecl_permute_bitrev_to_custom 2s 4s -50%
polyvecl_pointwise_acc_montgomery 2s 1s +100%
polyvecl_unpack_z 2s 4s -50%
polyw1_pack 2s 5s -60%
rej_eta 2s 3s -33%
shake128_finalize 2s 2s +0%
shake128_release 2s 4s -50%
shake128x4_absorb_once 2s 2s +0%
shake128x4_squeezeblocks 2s 1s +100%
shake256_finalize 2s 3s -33%
shake256x4_squeezeblocks 2s 3s -33%
use_hint 2s 3s -33%
fqscale 1s 3s -67%
polyz_unpack_native 1s 3s -67%
shake128_init 1s 3s -67%
shake256_absorb 1s 1s +0%

@oqs-bot
Copy link
Contributor

oqs-bot commented Feb 1, 2026

CBMC Results (ML-DSA-65)

Full Results (174 proofs)
Proof Status Current Previous Change
**TOTAL** 2373s 2200s +7.9%
sign_verify_internal 274s 206s +33%
polyvecl_pointwise_acc_montgomery_c 224s 211s +6%
mld_attempt_signature_generation 192s 195s -2%
polyvec_matrix_expand 140s 95s +47%
mld_invntt_layer 135s 107s +26%
poly_pointwise_montgomery_c 133s 127s +5%
rej_uniform_native 130s 126s +3%
mld_ntt_layer 83s 69s +20%
mld_ct_memcmp 81s 77s +5%
polyvec_matrix_expand_serial 62s 65s -5%
keccak_squeezeblocks_x4 42s 41s +2%
sign_signature_internal 40s 46s -13%
mld_compute_t0_t1_tr_from_sk_components 25s 25s +0%
rej_uniform 21s 20s +5%
fqmul 19s 20s -5%
polyveck_decompose 19s 15s +27%
poly_chknorm_c 18s 19s -5%
poly_uniform_eta_4x 18s 19s -5%
polymat_permute_bitrev_to_custom 17s 17s +0%
polyt0_unpack 16s 13s +23%
polyvec_matrix_pointwise_montgomery 16s 15s +7%
rej_uniform_c 16s 17s -6%
polyveck_use_hint 15s 9s +67%
keccakf1600x4_permute_native 14s 12s +17%
poly_uniform_4x 14s 14s +0%
mld_ntt_butterfly_block 13s 13s +0%
mld_check_pct 11s 7s +57%
sign 11s 8s +38%
sign_pk_from_sk 11s 5s +120%
polyveck_invntt_tomont 10s 8s +25%
keccak_absorb_once_x4 9s 10s -10%
mld_compute_pack_z 9s 4s +125%
mld_polyvecl_permute_bitrev_to_custom_native 9s 10s -10%
poly_invntt_tomont_c 9s 46s -80%
polyveck_ntt 9s 8s +12%
polyveck_shiftl 9s 8s +12%
keccakf1600_permute_native 8s 8s +0%
polyveck_add 8s 8s +0%
polyveck_caddq 8s 8s +0%
polyveck_power2round 8s 10s -20%
keccakf1600_permute 7s 9s -22%
mld_sample_s1_s2_serial 7s 8s -12%
polyveck_sub 7s 7s +0%
polyvecl_ntt 7s 9s -22%
mld_prepare_domain_separation_prefix 6s 4s +50%
poly_decompose_c 6s 8s -25%
polyeta_unpack 6s 4s +50%
polyveck_pointwise_poly_montgomery 6s 6s +0%
polyveck_reduce 6s 6s +0%
sign_keypair_internal 6s 8s -25%
sign_verify_pre_hash_shake256 6s 4s +50%
keccak_absorb 5s 5s +0%
keccakf1600_xor_bytes 5s 2s +150%
mld_ct_cmask_nonzero_u32 5s 2s +150%
mld_h 5s 4s +25%
mld_sample_s1_s2 5s 5s +0%
pack_sk 5s 3s +67%
poly_caddq_c 5s 4s +25%
poly_chknorm_native 5s 4s +25%
poly_use_hint_c 5s 6s -17%
polyveck_unpack_eta 5s 4s +25%
polyveck_unpack_t0 5s 4s +25%
polyvecl_pointwise_acc_montgomery_native 5s 6s -17%
polyvecl_uniform_gamma1 5s 2s +150%
rej_eta_c 5s 5s +0%
shake256x4_absorb_once 5s 2s +150%
sign_signature_pre_hash_internal 5s 4s +25%
sign_verify 5s 5s +0%
sign_verify_extmu 5s 2s +150%
unpack_hints 5s 5s +0%
keccakf1600_xor_bytes (big endian) 4s 6s -33%
mld_ct_get_optblocker_i64 4s 2s +100%
mld_ct_sel_int32 4s 2s +100%
ntt_native_x86_64 4s 3s +33%
pack_sig_z 4s 4s +0%
poly_add 4s 4s +0%
poly_decompose_native 4s 3s +33%
poly_ntt_native 4s 4s +0%
poly_pointwise_montgomery 4s 4s +0%
poly_sub 4s 4s +0%
poly_uniform 4s 5s -20%
poly_uniform_eta 4s 6s -33%
poly_uniform_gamma1_4x 4s 2s +100%
polyeta_pack 4s 4s +0%
polyt1_unpack 4s 2s +100%
polyveck_chknorm 4s 3s +33%
polyveck_make_hint 4s 4s +0%
polyz_unpack_c 4s 4s +0%
polyz_unpack_native 4s 3s +33%
power2round 4s 2s +100%
reduce32 4s 3s +33%
shake128_finalize 4s 3s +33%
shake128_squeeze 4s 4s +0%
shake256 4s 3s +33%
sign_keypair 4s 5s -20%
sign_signature 4s 4s +0%
sign_signature_pre_hash_shake256 4s 3s +33%
sys_check_capability 4s 2s +100%
unpack_sk 4s 3s +33%
caddq 3s 3s +0%
fqscale 3s 3s +0%
keccak_finalize 3s 2s +50%
keccak_squeeze 3s 2s +50%
make_hint 3s 2s +50%
mld_ct_abs_i32 3s 2s +50%
mld_ct_get_optblocker_u32 3s 2s +50%
mld_ct_get_optblocker_u8 3s 2s +50%
mld_value_barrier_u32 3s 2s +50%
mld_value_barrier_u8 3s 4s -25%
montgomery_reduce 3s 4s -25%
pack_sig_c_h 3s 6s -50%
poly_caddq_native_aarch64 3s 2s +50%
poly_challenge 3s 3s +0%
poly_chknorm 3s 2s +50%
poly_decompose 3s 3s +0%
poly_invntt_tomont 3s 4s -25%
poly_make_hint 3s 5s -40%
poly_ntt 3s 3s +0%
poly_ntt_c 3s 1s +200%
poly_pointwise_montgomery_native 3s 6s -50%
poly_power2round 3s 2s +50%
poly_reduce 3s 3s +0%
poly_uniform_gamma1 3s 3s +0%
poly_use_hint_native 3s 4s -25%
polyt0_pack 3s 4s -25%
polyveck_pack_eta 3s 3s +0%
polyvecl_chknorm 3s 4s -25%
polyvecl_pack_eta 3s 3s +0%
polyvecl_pointwise_acc_montgomery 3s 4s -25%
polyvecl_uniform_gamma1_serial 3s 3s +0%
polyvecl_unpack_eta 3s 4s -25%
polyz_pack 3s 2s +50%
polyz_unpack 3s 3s +0%
rej_eta_native 3s 4s -25%
shake128_absorb 3s 3s +0%
shake128x4_squeezeblocks 3s 2s +50%
shake256_finalize 3s 2s +50%
sign_verify_pre_hash_internal 3s 5s -40%
unpack_pk 3s 3s +0%
decompose 2s 2s +0%
keccak_init 2s 2s +0%
keccakf1600_extract_bytes (big endian) 2s 1s +100%
keccakf1600x4_extract_bytes 2s 2s +0%
keccakf1600x4_xor_bytes 2s 1s +100%
mld_ct_cmask_nonzero_u8 2s 2s +0%
mld_keccakf1600_extract_bytes 2s 2s +0%
mld_value_barrier_i64 2s 2s +0%
pack_pk 2s 1s +100%
poly_caddq 2s 2s +0%
poly_caddq_native 2s 3s -33%
poly_invntt_tomont_native 2s 3s -33%
poly_shiftl 2s 3s -33%
poly_use_hint 2s 3s -33%
polyt1_pack 2s 2s +0%
polyveck_pack_t0 2s 3s -33%
polyveck_pack_w1 2s 2s +0%
polyvecl_permute_bitrev_to_custom 2s 5s -60%
polyvecl_unpack_z 2s 3s -33%
polyw1_pack 2s 5s -60%
rej_eta 2s 5s -60%
shake128_init 2s 2s +0%
shake128x4_absorb_once 2s 3s -33%
shake256_absorb 2s 3s -33%
shake256_init 2s 1s +100%
shake256_squeeze 2s 3s -33%
shake256x4_squeezeblocks 2s 2s +0%
sign_open 2s 4s -50%
sign_signature_extmu 2s 4s -50%
unpack_sig 2s 1s +100%
use_hint 2s 3s -33%
keccakf1600x4_permute 1s 2s -50%
mld_ct_cmask_neg_i32 1s 3s -67%
shake128_release 1s 1s +0%
shake256_release 1s 1s +0%

@f15hr f15hr force-pushed the can_fail_must_check_port branch 3 times, most recently from 55edc32 to dcf9c9a Compare February 1, 2026 20:32
@f15hr
Copy link
Contributor Author

f15hr commented Feb 1, 2026

Changed CBMC_OBJECT_BITS to 12 in proofs/cbmc/polyvec_matrix_expand/Makefile to improve benchmark result for polyvec_matrix_expand.

@f15hr f15hr marked this pull request as ready for review February 1, 2026 21:22
@f15hr f15hr requested a review from a team as a code owner February 1, 2026 21:22
@mkannwischer mkannwischer force-pushed the can_fail_must_check_port branch from dcf9c9a to 7495e66 Compare February 8, 2026 05:38
Signed-off-by: Liam Fisher <liam.louis.fisher@gmail.com>
@mkannwischer mkannwischer force-pushed the can_fail_must_check_port branch from 7495e66 to 6adbd6f Compare February 8, 2026 05:43
Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @f15hr. Everything is looking good. I double checked that you did not miss any function.

@mkannwischer mkannwischer merged commit 8e997f7 into main Feb 8, 2026
371 checks passed
@mkannwischer mkannwischer deleted the can_fail_must_check_port branch February 8, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use MLD_MUST_CHECK_RETURN_VALUE for all functions with return values

3 participants