Use MLD_MUST_CHECK_RETURN_VALUE for all functions with return values#931
Merged
mkannwischer merged 1 commit intomainfrom Feb 8, 2026
Merged
Use MLD_MUST_CHECK_RETURN_VALUE for all functions with return values#931mkannwischer merged 1 commit intomainfrom
mkannwischer merged 1 commit intomainfrom
Conversation
Contributor
CBMC Results (ML-DSA-44)Full Results (174 proofs)
|
Contributor
CBMC Results (ML-DSA-87)Full Results (174 proofs)
|
Contributor
CBMC Results (ML-DSA-65)Full Results (174 proofs)
|
55edc32 to
dcf9c9a
Compare
Contributor
Author
|
Changed |
dcf9c9a to
7495e66
Compare
Signed-off-by: Liam Fisher <liam.louis.fisher@gmail.com>
7495e66 to
6adbd6f
Compare
mkannwischer
approved these changes
Feb 8, 2026
Contributor
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @f15hr. Everything is looking good. I double checked that you did not miss any function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #856
"Enforcing internal error checking discipline. In particular, this applies to the backend APIs that can now signal fallback -- this must always be checked."