Conversation
| word += this.requiredSpace(this.content(next)); | ||
| this.position ++; | ||
| } | ||
| } |
There was a problem hiding this comment.
No need this code anymore, we already handle this case (based on history aded33a)
alexander-akait
force-pushed
the
refactor-remove-unnecessary-stuff
branch
from
4b30cdb to
87e1dac
Compare
| throws('misplaced parenthesis', ':not(', 'Expected a closing parenthesis.'); | ||
| throws('misplaced parenthesis (2)', ':not)', 'Expected an opening parenthesis.'); | ||
| throws('misplaced parenthesis (3)', ':not((', 'Expected a closing parenthesis.'); | ||
| throws('misplaced parenthesis (4)', ':not))', 'Expected an opening parenthesis.'); |
There was a problem hiding this comment.
Many errors was broken (throw invalid error on ( and )) because we don't validate message
| this.error('Misplaced parenthesis.', { | ||
| index: this.nextToken[TOKEN.START_POS], | ||
| }); | ||
| } |
There was a problem hiding this comment.
No need this, error should be throw in parentheses function
alexander-akait
force-pushed
the
refactor-remove-unnecessary-stuff
branch
from
87e1dac to
db2651b
Compare
| return node; | ||
| } else { | ||
| this.unexpected(); | ||
| let nameRaw = this.content(this.tokens[this.position + 1]); |
There was a problem hiding this comment.
No need isNamedCombinator, we already do this in combinator()
alexander-akait
force-pushed
the
refactor-remove-unnecessary-stuff
branch
from
db2651b to
c2d56fd
Compare
alexander-akait
changed the title
|
Ready for review and need merge asap to continue work (avoid problem with merge) |
| t.deepEqual(tree.nodes[0].nodes[0].insensitive, false); | ||
| t.deepEqual(tree.nodes[0].nodes[0].raws.insensitiveFlag, 'qwer'); | ||
| }); | ||
|
|
There was a problem hiding this comment.
just rename and add more, nothing changes
|
Is this good to merge, @evilebottnawi ? |
|
@jonathantneal no, i think here we have breaking change here, let's keep open for next major release |
3 participants
Include:
No breaking changes(wrong)