chore: add git worktree docs and roborev configuration#92
chore: add git worktree docs and roborev configuration#92ian-flores wants to merge 2 commits intomainfrom
Conversation
|
Claude finished @ian-flores's task —— View job Review Complete
Reviewed both changed files ( |
There was a problem hiding this comment.
Review Summary
Clean, well-structured additions. Two minor observations:
CLAUDE.md — worktree path clarity
The relative path ../../.worktrees/ and the description referencing ptd-workspace/.worktrees/ assume a specific parent directory layout. If someone clones to a different location, ../../.worktrees/ won't resolve to ptd-workspace/.worktrees/. Consider either:
- Adding a note that the repo is expected to live at
ptd-workspace/team-operator/, or - Removing the
ptd-workspace/mention and relying solely on the relative../../.worktrees/form with a brief explanation of the assumed structure.
.roborev.toml
Minimal and straightforward — no concerns.
Overall this looks good to merge.
statik
left a comment
There was a problem hiding this comment.
@ian-flores this looks good to me. would you be up for adding a note to CONTRIBUTING.md?
I was thinking something like
roborev code review
If you would like to use roborev continuous code review, you will need to run roborev install-hook to install the commit hooks into your copy of the repo.
or, alternatively, should we put in CLAUDE.md a check or prompt asking the user if they want to install and use roborev?
Lytol
left a comment
There was a problem hiding this comment.
You could argue that the worktree stuff better belongs in a CLAUDE.local.md since it's a personal workflow thing, but I'm also fine with having it be a project norm. Your call, approved!
Summary
team-operator-<branch>).roborev.tomlconfiguring automatic code reviews with claude-code agentTest plan
just buildandjust testwork in a worktreeroborev status)