fix: use *int for audited jobs fields to preserve product defaults#89
Merged
ian-flores merged 1 commit intomainfrom Feb 19, 2026
Merged
fix: use *int for audited jobs fields to preserve product defaults#89ian-flores merged 1 commit intomainfrom
ian-flores merged 1 commit intomainfrom
Conversation
Audited jobs int fields in WorkbenchRServerConfig were plain int, causing Go zero values (0) to be written to rserver.conf when not explicitly set. This overrode product defaults (e.g. log-limit=10000, deletion-expiry=90). Change to *int so nil fields are omitted from the config, letting the product use its own built-in defaults.
ian-flores
force-pushed
the
add-audited-jobs-support
branch
from
7487e66 to
cf56d91
Compare
stevenolen
approved these changes
Feb 18, 2026
ian-flores
pushed a commit
that referenced
this pull request
Feb 19, 2026
## [1.11.2](v1.11.1...v1.11.2) (2026-02-19) ### Bug Fixes * use *int for audited jobs fields to preserve product defaults ([#89](#89)) ([709e580](709e580))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
intfields inWorkbenchRServerConfigto*intpointers so that unset fields are omitted fromrserver.confinstead of being written as=0log-limit=10000,deletion-expiry=90,vanilla-required=1)0), it is still written correctlyTest plan
TestWorkbenchConfig_AuditedJobs- verifies all explicitly set fields are writtenTestWorkbenchConfig_AuditedJobsPartial- verifies nil*intfields are omitted from config outputTestSiteAuditedJobsConfiguration- verifies full config propagation with pointer typesTestSiteAuditedJobsPartialConfiguration- verifies unset fields are nil (not zero)