chore: add git worktree docs and roborev configuration#128
Merged
ian-flores merged 5 commits intomainfrom Feb 24, 2026
Merged
Conversation
Lytol
reviewed
Feb 19, 2026
Contributor
Lytol
left a comment
Lytol
left a comment
There was a problem hiding this comment.
All the roborev and CLAUDE.md stuff seems great! The .envrc will stomp on my own project-specific stuff, which feels heavy-handed. What do you think?
Contributor
There was a problem hiding this comment.
Putting an envrc in the repo kind of takes up a typically developer-controlled local file. What about putting it in a .envrc.recommended or similar and then documenting via the README?
Add bastion_instance_type configuration field to AzureWorkloadConfig, matching AWS naming for cross-cloud consistency. Defaults to "Standard_B1s" for backward compatibility.
Avoids stomping on developer-local .envrc customizations, per review feedback from Lytol and statik on PR #128. Developers should copy envrc.recommended to .envrc locally. Update CLAUDE.md instructions accordingly.
This reverts commit 0cd88f0.
ian-flores
commented
Feb 24, 2026
Contributor
Author
ian-flores
left a comment
ian-flores
left a comment
There was a problem hiding this comment.
Thanks both! Renamed .envrc to envrc.recommended to keep local customizations out of the way — CLAUDE.md now instructs devs to copy it to .envrc before running direnv allow. Consistent with the existing keycloak/envrc.recommended pattern in the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.envrcwithsource_upso direnv resolvesPTDcorrectly in both main checkout and worktrees.roborev.tomlconfiguring automatic code reviews with claude-code agentTest plan
direnv allowworks in main checkout and in a worktreejust build-cmdproduces a working binary in a worktreeroborev status)