Added recursivity for configuring moreoption by entity#3
Merged
Conversation
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Contributor
Author
|
Waiting #1 |
Rom1-B
requested changes
Oct 14, 2025
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Lainow
force-pushed
the
fix-recursivity
branch
from
1b1a033 to
0c0fe50
Compare
Rom1-B
requested changes
Nov 27, 2025
tests/Units/ConfigTest.php
Outdated
Comment on lines
1217
to
1222
| $child_entity = new \Entity(); | ||
| $child_entity_id = $child_entity->add([ | ||
| 'name' => 'Child Entity Test', | ||
| 'entities_id' => 0, // Parent entity as parent | ||
| ]); | ||
| $this->assertGreaterThan(0, $child_entity_id); |
Contributor
There was a problem hiding this comment.
Please use createItem() wherever possible.
The same applies to updateItem().
Lainow
force-pushed
the
fix-recursivity
branch
from
b1d32e0 to
a9c7ebb
Compare
Rom1-B
approved these changes
Jan 9, 2026
|
@Lainow can you rebase |
|
Please fix CI |
Rom1-B
reviewed
Jan 27, 2026
Lainow
force-pushed
the
fix-recursivity
branch
from
b08885f to
571fe59
Compare
stonebuzz
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.