Skip to content

Fix: deploy command crashes on API response string access #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fthues wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: deploy command crashes on API response string access #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f10ce8
fix: handle string response in deploy command output
fthues Feb 15, 2026
fbb1061
fix: cast deployment ID to int for return type compliance
fthues Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/Commands/DeployCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ protected function deploy($serverId, $siteId, $domain, $data, $isScheduled = fal
exit();
}

$this->info(Arr::first($deploying['data'])['message']);
$firstValue = Arr::first($deploying['data']);
$this->info(is_array($firstValue) ? $firstValue['message'] : $firstValue);

if ($isScheduled) {
return;
Expand Down Expand Up @@ -186,7 +187,7 @@ private function getLatestDeploymentId(int $serverId, int $siteId): ?int
try {
$deployment = $poller->getLatestDeployment($serverId, $siteId);

return $deployment['id'] ?? null;
return isset($deployment['id']) ? (int) $deployment['id'] : null;
} catch (Exception $e) {
$this->error('Failed to get latest deployment: '.$e->getMessage());

Expand Down