Cookie expire date can be integer or float#67
Open
stloyd wants to merge 1 commit intoplaywright-php:mainfrom
Open
Cookie expire date can be integer or float#67stloyd wants to merge 1 commit intoplaywright-php:mainfrom
stloyd wants to merge 1 commit intoplaywright-php:mainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
stloyd
force-pushed
the
bugfix/cookie-expire-as-float
branch
from
ec0e5cd to
dfcc5f3
Compare
Refactor cookie validation into internal class to reduce duplication
stloyd
force-pushed
the
bugfix/cookie-expire-as-float
branch
from
dfcc5f3 to
44f3ff4
Compare
Contributor
Author
|
@smnandre Do you think this is overkill, or do you need more time to have a deeper look? Sorry if I sound harsh ;) |
Member
|
Please.... a contributor helping an OSS project... speak the way you want, this will never be harsh to me :) |
Member
|
Yeah I wanted to test it locally, and was busy working on the Symfony bundle this week-end ... I'm gonna look later tonight if that's ok for you ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor cookie validation into internal class to reduce duplication