Skip to content

br: sys collation check#21306

Merged
ti-chi-bot[bot] merged 14 commits intopingcap:masterfrom
Leavrth:sys_collation_scheck
Feb 13, 2026
Merged

br: sys collation check#21306
ti-chi-bot[bot] merged 14 commits intopingcap:masterfrom
Leavrth:sys_collation_scheck

Conversation

@Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Jan 30, 2026

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 30, 2026
@hfxsd hfxsd self-assigned this Feb 5, 2026
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Feb 5, 2026
@hfxsd hfxsd mentioned this pull request Feb 5, 2026
14 tasks
@hfxsd hfxsd requested a review from BornChanger February 5, 2026 13:20
@hfxsd hfxsd added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Feb 5, 2026
> 已知问题:从 v7.2.0 版本开始,新建集群的部分系统表字段变为大小写不敏感。然而,对于从 v7.2.0 之前的版本**在线升级**到 v7.2.0 及以上版本的集群,对应的系统表字段仍然大小写敏感。如果在这两类集群之间进行包含系统表的备份和恢复操作,可能会失败。详情参见 [Issue #43717](https://github.com/pingcap/tidb/issues/43717)。
> - 已知问题:从 v7.2.0 开始,新建集群的部分系统表字段变为大小写不敏感。然而,对于从 v7.2.0 之前的版本**在线升级**到 v7.2.0 及以上版本的集群,对应的系统表字段仍然大小写敏感。如果在这两类集群之间进行包含系统表的备份和恢复操作,可能会失败。详情参见 [Issue #43717](https://github.com/pingcap/tidb/issues/43717)。
>
> - 从 v8.5.5 开始,如果旧集群系统表中不存在大小写冲突的记录(例如同时存在 `test.t1` 和 `test.T1`),在恢复时可以指定 BR 参数 `--sys-check-collation`。BR 会检查系统表数据在不同排序规则 (Collation) 下的兼容性:如果兼容,则可以成功恢复来自旧版本的备份;如果不兼容,则 BR 会报错并终止恢复。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

客户如何把你的建议落地呢?

  1. 如何检查大小写冲突的记录?
  2. 直接无脑设置 --sys-check-collation 有什么危害么?

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2026
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 9, 2026
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 13, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 13, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-02-13 01:17:08.089077095 +0000 UTC m=+153981.169067800: ☑️ agreed by hfxsd.

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 13, 2026

@BornChanger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd added the lgtm label Feb 13, 2026
@hfxsd
Copy link
Collaborator

hfxsd commented Feb 13, 2026

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 13, 2026
@ti-chi-bot ti-chi-bot bot merged commit 848b7a1 into pingcap:master Feb 13, 2026
10 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #21364.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 13, 2026
14 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Feb 13, 2026
ti-chi-bot bot pushed a commit that referenced this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants