*: replace dumpling with tidb/dumpling by Little-Wallace · Pull Request #2263 · pingcap/dm

Little-Wallace · 2021-10-26T03:56:22Z

What problem does this PR solve?

replace dumpling with tidb/dumpling. the repo github.com/pingcap/dumpling has been merged into github.com/pingcap/tidb

close https://github.com/pingcap/dm/issues/2259

What is changed and how it works?

Check List

Tests

No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation
Need to update the dm/dm-ansible
Need to be included in the release note

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

Co-authored-by: lance6716 <lance6716@gmail.com> Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

ti-chi-bot · 2021-10-26T03:56:23Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Ehco1996
lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

Ehco1996 · 2021-10-26T05:16:30Z

related to https://github.com/pingcap/dm/issues/2259

Ehco1996

LGTM

lichunzhu

LGTM

lichunzhu · 2021-10-26T07:00:22Z

/merge

ti-chi-bot · 2021-10-26T07:00:26Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: ad92b60

ti-chi-bot · 2021-10-26T07:00:34Z

@Little-Wallace: Your PR was out of date, I have automatically updated it for you.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

lichunzhu · 2021-10-26T07:01:34Z

/hold

lichunzhu · 2021-10-26T07:03:02Z

CHANGELOG.md

 - Support retry task on the `invalid connection` error for binlog replication [#66](https://github.com/pingcap/dm/pull/66)
 - Support generating `-schema-create.sql` files automatically for full migration [#186](https://github.com/pingcap/dm/pull/186)
- Use [TiDB SQL Parser](https://github.com/pingcap/parser) to parse and restore DDL statements in binlog query events, and remove the `use db` statement when replicating to downstream [#54](https://github.com/pingcap/dm/pull/54)
+- Use [TiDB SQL Parser](https://github.com/pingcap/tidb/parser) to parse and restore DDL statements in binlog query events, and remove the `use db` statement when replicating to downstream [#54](https://github.com/pingcap/dm/pull/54)


Suggested change

- Use [TiDB SQL Parser](https://github.com/pingcap/tidb/parser) to parse and restore DDL statements in binlog query events, and remove the `use db` statement when replicating to downstream [#54](https://github.com/pingcap/dm/pull/54)

- Use [TiDB SQL Parser](https://github.com/pingcap/tidb/tree/master/parser) to parse and restore DDL statements in binlog query events, and remove the `use db` statement when replicating to downstream [#54](https://github.com/pingcap/dm/pull/54)

sleepymole · 2021-10-26T07:03:57Z

pkg/parser/common.go

 const (
 	// SingleRenameTableNameNum stands for number of TableNames in a single table renaming. it's 2 after
-	// https://github.com/pingcap/parser/pull/1021
+	// https://github.com/pingcap/tidb/parser/pull/1021


This line should be reverted.

glorv · 2021-10-26T11:28:03Z

ping @Little-Wallace , dumpling is merged into tidb now.

Little-Wallace and others added 25 commits September 24, 2021 13:30

support lightning

10ab568

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

fix bug

df036b6

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

Update dm/config/subtask.go

44474f5

Co-authored-by: lance6716 <lance6716@gmail.com> Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

fix repeat

789997c

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

address comment

490247c

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

add config

a836389

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

change test to tidb backend

c2edae1

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

add some comment

b950088

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

address comment

17e9fcd

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

fix fmt

f9a73a5

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

fix comment

8026c1e

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

fix test

9dd6693

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

Merge branch 'master' into lightning

b4d9bdd

fix config test

0bbaeb4

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

Merge branch 'lightning' of github.com:Little-Wallace/dm into lightning

c59ae59

fix fmt

6b0dc8c

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

fix db name

ac64b6f

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

add sql mode

6fb6334

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

fix meta

9fed14c

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

remove timestamp

4aed643

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

Merge branch 'master' into lightning

0062d81

fix tablename quotes

df256a3

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

support time zone

99d9487

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

remove checkpoint

c921c46

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

replace dumpling

557241d

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

ti-chi-bot requested review from GMHDBJD and lichunzhu October 26, 2021 03:56

ti-chi-bot added the size/L label Oct 26, 2021

Merge branch 'master' into checkpoint

0ac6da0

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

ti-chi-bot added size/M and removed size/L labels Oct 26, 2021

revert lightning

ad92b60

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

Ehco1996 approved these changes Oct 26, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Oct 26, 2021

lichunzhu approved these changes Oct 26, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Oct 26, 2021

ti-chi-bot added the status/can-merge label Oct 26, 2021

Merge branch 'master' into checkpoint

858bff7

ti-chi-bot added the do-not-merge/hold label Oct 26, 2021

lichunzhu reviewed Oct 26, 2021

View reviewed changes

sleepymole reviewed Oct 26, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: replace dumpling with tidb/dumpling#2263

*: replace dumpling with tidb/dumpling#2263
Little-Wallace wants to merge 28 commits intopingcap:masterfrom
Little-Wallace:checkpoint

Little-Wallace commented Oct 26, 2021 •

edited by Ehco1996

Loading

Uh oh!

ti-chi-bot commented Oct 26, 2021 •

edited

Loading

Uh oh!

Ehco1996 commented Oct 26, 2021

Uh oh!

Ehco1996 left a comment

Uh oh!

lichunzhu left a comment

Uh oh!

lichunzhu commented Oct 26, 2021

Uh oh!

ti-chi-bot commented Oct 26, 2021

Uh oh!

ti-chi-bot commented Oct 26, 2021

Uh oh!

lichunzhu commented Oct 26, 2021

Uh oh!

lichunzhu Oct 26, 2021

Uh oh!

sleepymole Oct 26, 2021 •

edited

Loading

Uh oh!

glorv commented Oct 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	- Use [TiDB SQL Parser](https://github.com/pingcap/tidb/parser) to parse and restore DDL statements in binlog query events, and remove the `use db` statement when replicating to downstream [#54](https://github.com/pingcap/dm/pull/54)
	- Use [TiDB SQL Parser](https://github.com/pingcap/tidb/tree/master/parser) to parse and restore DDL statements in binlog query events, and remove the `use db` statement when replicating to downstream [#54](https://github.com/pingcap/dm/pull/54)

Conversation

Little-Wallace commented Oct 26, 2021 • edited by Ehco1996 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Uh oh!

ti-chi-bot commented Oct 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ehco1996 commented Oct 26, 2021

Uh oh!

Ehco1996 left a comment

Choose a reason for hiding this comment

Uh oh!

lichunzhu left a comment

Choose a reason for hiding this comment

Uh oh!

lichunzhu commented Oct 26, 2021

Uh oh!

ti-chi-bot commented Oct 26, 2021

Uh oh!

ti-chi-bot commented Oct 26, 2021

Uh oh!

lichunzhu commented Oct 26, 2021

Uh oh!

lichunzhu Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

sleepymole Oct 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

glorv commented Oct 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Little-Wallace commented Oct 26, 2021 •

edited by Ehco1996

Loading

ti-chi-bot commented Oct 26, 2021 •

edited

Loading

sleepymole Oct 26, 2021 •

edited

Loading