Implement scan_factor and max_candidates for query#617
Merged
austin-denoble merged 6 commits intomainfrom Feb 19, 2026
Merged
Conversation
…n_factor and max_candidates
…b_data/index.py, db_data/index_asyncio.py, db_data/resources/sync/vector.py, and db_data/resources/asyncio/vector_asyncio.py. update IndexRequestFactory.query_request() to handle max_candidates and scan_factor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
….query_namespaces()
…ng scan_factor and max_candidates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There are new parameters available on
queryfor indexes with dedicated read nodes:scan_factormax_candidatesThese were pulled into the
2025-10API release and need to be added to the clients.Solution
2025-10to pull inscan_factorandmax_candidates.max_candidatesandscan_factorto the following resources and thread things through the API:VectorResourceAsyncio.query()&&VectorResourceAsyncio.query_namespaces()VectorResource.query()&&VectorResource.query_namepspaces()Index.query()&&Index.query_namespaces()_IndexAsyncio.query()&&_IndexAsyncio.query_namespaces()IndexRequestFactory.query_request()GRPCIndex.query()&& `GRPCIndex.query_namespaces()Type of Change
Test Plan
CI - unit and integration tests
Note
Medium Risk
Touches core query request construction and propagates new parameters through both REST and gRPC layers; risk is mainly incorrect serialization/forwarding or validation edge cases, mitigated by added unit coverage.
Overview
Adds two new query tuning parameters,
scan_factorandmax_candidates, to theQueryRequestschema and surfaces them through all query entrypoints (Index.query,query_namespaces, sync/async vector resources, andGRPCIndex.query).Regenerates the 2025-10 OpenAPI and protobuf bindings to include the new fields (with validations and typing) and updates the request factory to include them only when provided. Unit tests are expanded to assert correct forwarding/omission behavior for REST, asyncio, and gRPC query calls, and the generated API repo SHA is bumped.
Written by Cursor Bugbot for commit 0c40a43. This will update automatically on new commits. Configure here.