Allow independent scrolling of nav, filter and main sections#470
Allow independent scrolling of nav, filter and main sections#470abhishek-compro wants to merge 7 commits intopiccolo-orm:masterfrom
Conversation
|
@dantownsend I have added bit extra styling. Let me know your thoughts. The border radius isn't consistently applied to all places though. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #470 +/- ##
==========================================
+ Coverage 93.42% 94.04% +0.62%
==========================================
Files 5 5
Lines 365 403 +38
==========================================
+ Hits 341 379 +38
Misses 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| background-color: rgba(0, 0, 0, 0.1); | ||
| overflow-y: auto; | ||
| height: 100%; | ||
| height: calc(100vh - 5rem); |
There was a problem hiding this comment.
Is the 5rem the approx height of the top nav bar?
There was a problem hiding this comment.
It is a rounded off value and enough to not put a global scroll bar. The only thing is that there is a slight footer padding which is both a good and bad thing depending on how you see it.
Let me know if you need any modifications. |
|
@abhishek-compro That looks good to me 👍 |
|
This PR has been marked as stale because it has been open for 30 days with no activity. Are there any blockers, or should this be closed? |
Fixes #467