440 Frontend doesn't take into account the page_size parameter

[dantownsend]

Resolves #440

[sinisaos]

@dantownsend I don't know if this helps, but the Playwright test passes if we change the response url from this

piccolo_admin/e2e/test_sort_columns.py

Lines 65 to 70 in 309932f

	with page.expect_response(
	lambda response: response.url
	== f"{BASE_URL}/api/tables/sorted_columns/?__readable=true&__order=integer,letter&__page_size=15&__page=1" # noqa: E501
	and response.request.method == "GET"
	and response.status == 200
	):

to this

with page.expect_response(
    lambda response: "/tables/sorted_columns/?" in response.url
):

[dantownsend]

@dantownsend I don't know if this helps, but the Playwright test passes if we change the response url from this

piccolo_admin/e2e/test_sort_columns.py

Lines 65 to 70 in 309932f

	with page.expect_response(
	lambda response: response.url
	== f"{BASE_URL}/api/tables/sorted_columns/?__readable=true&__order=integer,letter&__page_size=15&__page=1" # noqa: E501
	and response.request.method == "GET"
	and response.status == 200
	):

to this

with page.expect_response(
    lambda response: "/tables/sorted_columns/?" in response.url
):

@sinisaos Thanks - I'll give that a go!

[github-actions]

This PR has been marked as stale because it has been open for 30 days with no activity. Are there any blockers, or should this be closed?

[hoosnick]

merge this PR @dantownsend @sinisaos

[sinisaos]

@hoosnick You have to wait @dantownsend for that because I don't have permission to merge things. This PR also needs to fix the failing test, and @dantownsend was working on that.

[sinisaos]

@dantownsend @hoosnick The code from this PR actually doesn't work and that's why the Playwright test fails. After #468 and #469 are merged, I'll create a PR to add

1. __page and __page_size to the query parameters (for proper filtering with query parameters from the URL)
2. I'll also add __order to the query parameters because without it the ordering doesn't work correctly (for proper filtering with query parameters from the URL)
3. And finally I'll add code for the page_size parameter (instead of this PR) which will be done based on user page_size param (if parameter does not exists in config, default stays 15).

I already have code for all that.

[github-actions]

This PR has been marked as stale because it has been open for 30 days with no activity. Are there any blockers, or should this be closed?