Open
Conversation
updates: - [github.com/psf/black: 24.4.2 → 24.8.0](psf/black@24.4.2...24.8.0) - [github.com/pycqa/flake8: 7.1.0 → 7.1.1](PyCQA/flake8@7.1.0...7.1.1)
Add contribution
Update contributors
Fix type errors in exporting history after manually adding peaks
[pre-commit.ci] pre-commit autoupdate
Make sure peak detection works with negative signals
github-actions
bot
added
Documentation
smoia
reviewed
Oct 30, 2024
smoia
reviewed
Oct 30, 2024
| locs, heights = signal.find_peaks(data[:], distance=cdist, height=thresh) | ||
|
|
||
| # check if data is negative, if so make it all positive and continue with signal | ||
| phys_signal = data.data - data.data.min() if data.data.min() < 0 else data.data |
Member
There was a problem hiding this comment.
I was thinking that maybe we can just always work with data at min=0 for peak detection (it doesn't rescale the data for real). That should make percentages for thresh easier to work with. Thoughts?
Suggested change
| phys_signal = data.data - data.data.min() if data.data.min() < 0 else data.data | |
| phys_signal = data.data - data.data.min() |
smoia
approved these changes
Oct 30, 2024
Member
smoia
left a comment
smoia
left a comment
There was a problem hiding this comment.
See the suggestion on min()=0, for the rest all good, thanks!
smoia
added
the
Minormod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate latest peakdet changes in prep4phys
Proposed Changes
Change Type
bugfix(+0.0.1)minor(+0.1.0)major(+1.0.0)refactoring(no version update)test(no version update)infrastructure(no version update)documentation(no version update)otherChecklist before review