Conversation
.github/config.yml
Outdated
|  | ||
|
|
||
| 🎉 Congrats on merging your first pull request in this repo! We appreciate your contribution to the Physiopy community! | ||
| :eyes: Please check that your contribution is correctly reported in the repo's README and on Physiopy's website! No newline at end of file |
There was a problem hiding this comment.
Should we add the hyperlink to the Physiopy website home page ?
https://physiopy.github.io/
m-miedema
left a comment
There was a problem hiding this comment.
Re: mkdocs, I'm not sure that that would change anything - maybe the simplest thing is to assume it won't and then test it? It's good to know since I imagine this might also have implications for the Community Practices repo!
I do think it's good to have a contributors readme but was wondering about the directive to check that contributions are accurately reflected on the website. Is the website page one that gets manually updated every so often? I wouldn't want someone to expect to see changes reflected there instantaneously.
|
Yes true, I think it will work, and we can test it and change accordingly if not :-) You make a good point. The wording kind of suggests that it would automatically happen - contributors don't get added automatically in either place mentioned currently. I guess it's a flag for people to check and follow up, but open to changing wording! |
But then again, this won't happen regularly, only the first time someone opens a PR, so perhaps okay to leave for now (as a general reminder for them to check their contributions going forward) |
That makes sense to me! I think as long as we have a link to the Contributor's Guide, the wording there sets the correct expectation. |
|
@m-miedema shall we merge for now? Or make some changes to the wording first? |
Closes #51
Adds workflows
Proposed Changes
Questions for reviewers
Change Type
bugfixrefactoringinfrastructuredocumentationotherChecklist before review